fix: Increase logging #2351
Merged
fix: Increase logging #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching our logger from `bunyan` to `winston` we changed the level from `trace` to `info` by mistake, thus decreasing the quantity of useful logs we get when running the app. We just change the level back to `trace`.
We made a mistake in the function listing log files to send the last one as paths returned by `fs.readdir()` are sorted alpabetically and log files' names contain numbers which need `String.localeCompare` to be sorted properly. e.g. when we have new log file names and old ones at the same time, we can have the following order : 1. `logs.txt` # old format for current log file 2. `logs.txt.0` # old format for previous day log file 3. `logs.txt.1` # old format 4. `logs.txt.2` # old format 5. `logs.txt.2024-10-22` # new format for previous day log file 6. `logs.txt.2024-10-23` # new format for current day log file 7. `logs.txt.3` # old format In this case, when trying to send the latest log file with a support request, we'd send `logs.txt.3` as it is the latest one in alpabetical order when we intended to send `logs.txt.2024-10-23`. By using `String.localeCompare` with its `numeric: true` option, we make sure numbers in strings are sorted in a numerical order : 1. `logs.txt` # old format for current log file 2. `logs.txt.0` # old format for previous day log file 3. `logs.txt.1` # old format 4. `logs.txt.2` # old format 5. `logs.txt.3` # old format 6. `logs.txt.2024-10-22` # new format for previous day log file 7. `logs.txt.2024-10-23` # new format for current day log file
taratatach
force-pushed
the
fix/sending-useful-logs
branch
from
b11ecef
to
8470d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back the debugging logs we're used to so we can help our users.
Please make sure the following boxes are checked: