feat: Support voice_state/model_type for audio.voices.list #269
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant VoicesClient
participant API
User->>VoicesClient: list(voice_state, **kwargs)
VoicesClient->>API: GET /voices?voice_state=... + extra options
API-->>VoicesClient: Response (filtered voices)
VoicesClient-->>User: List of Voice objects (with state and model_type)
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 89.58% 89.59% +0.01%
==========================================
Files 74 74
Lines 6959 6971 +12
==========================================
+ Hits 6234 6246 +12
Misses 725 725
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
cozepy/audio/voices/__init__.py (1)
11-15: Consider the semantic meaning of theALLenum valueThe
VoiceStateenum is well-defined, but theALLvalue seems to represent a filter option rather than an actual voice state. Consider whether this belongs in the enum or should be handled differently in the filtering logic.Alternatively, you could handle the "all states" case by passing
Noneas thevoice_stateparameter, which would be more semantically accurate.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
cozepy/__init__.py(2 hunks)cozepy/audio/voices/__init__.py(7 hunks)
🔇 Additional comments (6)
cozepy/__init__.py (2)
19-19: LGTM: Clean import additionThe import correctly adds
VoiceStatealongside the existingVoiceimport, maintaining consistency with the module's structure.
226-226: LGTM: Proper public API exportThe addition of
VoiceStateto the__all__list is correctly placed and follows the established pattern for audio voice-related exports.cozepy/audio/voices/__init__.py (4)
1-1: LGTM: Proper enum importThe enum import is correctly added to support the new
VoiceStateenumeration.
48-50: LGTM: Backwards-compatible model extensionThe optional
statefield addition is properly typed and maintains backwards compatibility with existing code.
146-153: LGTM: Proper parameter handlingThe
voice_stateparameter is correctly included in the request params and properly handled withremove_none_valuesto avoid sending unnecessary parameters.
248-255: LGTM: Consistent parameter handlingThe async method properly handles the
voice_stateparameter consistently with the sync version, usingremove_none_valuesto filter out None values.
chyroc
changed the title
Summary by CodeRabbit