chore: remove CowEvcWrapper and fix compile notes in remaining legacy #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the CowEvcWrapper and fix any compile notes that have yet to be fixed.
Context
We no longer use the CowEvcWrapper (in favor of the 3 specialized wrappers), so lets get those removed.
In addition, there are a number of places where compilation warnings/notes are being emitted, so we can get those fixed now and make it policy to not have any notes in the CI.
Finally, we also remove dependencies on the original Cow repo as the
CowWrapperprovides all the datastructures needed anyway and we should only be using one set of data structures for compiler consistency reasons.Out of Scope
there may be some slightly unnecessary changes in the PR in order to pave the way for the wrappers. please let me know if this is concern and I can recategorize.
Testing Instructions
verify that
forge build --deny notessucceeds (no warnings)