Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoverletReport MSBuild item in the CoverageResultTask MSBuild task #932

Merged

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Aug 25, 2020

So that the coverlet reports can be easily used by other MSBuild tasks. For example, using ReportGenerator to generate an html coverage report.

<Target Name="GenerateHtmlCoverageReport" AfterTargets="GenerateCoverageResultAfterTest">
  <ReportGenerator ReportFiles="@(CoverletReport)" TargetDirectory="../html-coverage-report" />
</Target>

@MarcoRossignoli MarcoRossignoli added driver-msbuild Issue related to msbuild driver untriaged To be investigated and removed untriaged To be investigated labels Aug 25, 2020
@MarcoRossignoli
Copy link
Collaborator

Thanks I'll take a look asap!

So that the coverlet reports can be easily used by other MSBuild tasks. For example, using [ReportGenerator](https://github.com/danielpalme/ReportGenerator#usage--command-line-parameters) to generate an html coverage report.

```xml
<Target Name="GenerateHtmlCoverageReport" AfterTargets="GenerateCoverageResultAfterTest">
  <ReportGenerator ReportFiles="@(CoverletReport)" TargetDirectory="../html-coverage-report" />
</Target>
```
@0xced 0xced force-pushed the CoverletReport-MSBuild-item branch from 9af53b4 to c4bffe0 Compare September 15, 2020 21:01
@0xced
Copy link
Contributor Author

0xced commented Sep 15, 2020

I just rebased on master, I hope you get the chance to have a look at it.

Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tonerdo seems a good addition for msbuild driver, can you double check?

@tonerdo
Copy link
Collaborator

tonerdo commented Oct 6, 2020

Thanks @0xced

@tonerdo tonerdo merged commit 46b4125 into coverlet-coverage:master Oct 6, 2020
@0xced 0xced deleted the CoverletReport-MSBuild-item branch October 6, 2020 05:07
@0xced
Copy link
Contributor Author

0xced commented Oct 6, 2020

Excellent, thanks for merging! Do you have an estimate when a new coverlet.msbuild NuGet package will ship with those changes? Now that the documentation is merged, it could lead to confusion since the current package (2.9.0) does not support the CoverletReport MSBuild item yet.

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Oct 6, 2020

Not yet...but we're close I think, we need some more PR to align versions number(we're changing schema version) and after we can deploy, we've one not easy coverage issue with new switch pattern #936 and we need to understand if deploy a version and fix after or not(I don't know atm how much time to solve, bit busy period for me)

@mikes-gh
Copy link
Contributor

mikes-gh commented Jan 3, 2021

Just got hit by this as new user. I presume this is not released. I struggled with the docs for ages

@mikes-gh mikes-gh mentioned this pull request Jan 3, 2021
@MarcoRossignoli
Copy link
Collaborator

Yep is not released yet, we missed to add this to the changelog as unreleased, we apologize.

@0xced
Copy link
Contributor Author

0xced commented Jan 20, 2021

Released since version 3.0.0. 🎉

0xced added a commit to serilog-contrib/serilog-formatting-log4net that referenced this pull request Jan 20, 2021
The `CollectCoverletReport` target can now be removed as coverlet.msbuild produces a `CoverletReport` MSBuild item by default.

Pull request: coverlet-coverage/coverlet#932
Changelog: https://github.com/coverlet-coverage/coverlet/blob/070f2b47ef616a62e7fedc89cfec02eac9560ca9/Documentation/Changelog.md#release-date-2021-01-09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver-msbuild Issue related to msbuild driver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants