-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CoverletReport
MSBuild item in the CoverageResultTask MSBuild task
#932
Add CoverletReport
MSBuild item in the CoverageResultTask MSBuild task
#932
Conversation
Thanks I'll take a look asap! |
So that the coverlet reports can be easily used by other MSBuild tasks. For example, using [ReportGenerator](https://github.com/danielpalme/ReportGenerator#usage--command-line-parameters) to generate an html coverage report. ```xml <Target Name="GenerateHtmlCoverageReport" AfterTargets="GenerateCoverageResultAfterTest"> <ReportGenerator ReportFiles="@(CoverletReport)" TargetDirectory="../html-coverage-report" /> </Target> ```
9af53b4
to
c4bffe0
Compare
I just rebased on master, I hope you get the chance to have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @tonerdo seems a good addition for msbuild driver, can you double check?
Thanks @0xced |
Excellent, thanks for merging! Do you have an estimate when a new |
Not yet...but we're close I think, we need some more PR to align versions number(we're changing schema version) and after we can deploy, we've one not easy coverage issue with new switch pattern #936 and we need to understand if deploy a version and fix after or not(I don't know atm how much time to solve, bit busy period for me) |
Just got hit by this as new user. I presume this is not released. I struggled with the docs for ages |
Yep is not released yet, we missed to add this to the changelog as unreleased, we apologize. |
Released since version 3.0.0. 🎉 |
The `CollectCoverletReport` target can now be removed as coverlet.msbuild produces a `CoverletReport` MSBuild item by default. Pull request: coverlet-coverage/coverlet#932 Changelog: https://github.com/coverlet-coverage/coverlet/blob/070f2b47ef616a62e7fedc89cfec02eac9560ca9/Documentation/Changelog.md#release-date-2021-01-09
So that the coverlet reports can be easily used by other MSBuild tasks. For example, using ReportGenerator to generate an html coverage report.