Skip lambda cached field #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
commented
Mar 7, 2020
| .AssertBranchesCovered(BuildConfiguration.Debug, (16, 0, 0), (16, 1, 1), (43, 0, 3), (43, 1, 1), (43, 2, 1), (43, 3, 1), (43, 4, 0)) | ||
| // Real branch should be 2, we should try to remove compiler generated branch in method ContinuationNotCalled/ContinuationCalled | ||
| // for Continuation state machine | ||
| .ExpectedTotalNumberOfBranches(BuildConfiguration.Debug, 2); |
There was a problem hiding this comment.
fixed also this bug(from 4 down to 2 real branches)
MarcoRossignoli
commented
Mar 7, 2020
|
|
||
| // Unexpected branches - generated by compiler to cache delegate instance |
There was a problem hiding this comment.
fixed also this bug
MarcoRossignoli
commented
Mar 7, 2020
| return false; | ||
| } | ||
|
|
||
| private static bool SkipLambdaCachedField(Instruction instruction) |
MarcoRossignoli
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730
The issue is related to lambda cached fields, that triggers another issue on coverage calculation.
I've also refactored a bit
GetBranchPointsto keep code flow clear.cc: @matteoerigozzi can you take a look?