-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move/Pin to 3.1 runtime #688
Move/Pin to 3.1 runtime #688
Conversation
eng/build.yml
Outdated
- task: DotNetCoreCLI@2 | ||
displayName: Test | ||
inputs: | ||
command: test | ||
arguments: -c $(BuildConfiguration) --no-build /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:Include=[coverlet.*]* /p:Exclude=[coverlet.tests.remoteexecutor]* | ||
testRunTitle: $(Agent.JobName) | ||
|
||
- script: dotnet pack -c $(BuildConfiguration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet/sdk#3001 new behaviour I think that pack will build core project, not a great issue pack is pretty fast.
@@ -1,7 +1,12 @@ | |||
steps: | |||
- task: UseDotNet@2 | |||
inputs: | |||
version: 2.2.402 | |||
version: 2.2.207 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have some integration tests done with netcoreapp2.1;netcoreapp2.2
and roll forward major is not supported by default https://github.com/dotnet/designs/blob/master/accepted/runtime-binding.md
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp list |
CI/CD Pipelines for this repository: |
Pin 3.1 runtime, in this way we can have a wide integration tests available
Currently pack shows a warning
I've opened an issue on nuget repo seems a bug NuGet/Home#8941
cc: @tonerdo @petli