Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move/Pin to 3.1 runtime #688

Merged
merged 14 commits into from
Jan 14, 2020

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Jan 13, 2020

Pin 3.1 runtime, in this way we can have a wide integration tests available

Currently pack shows a warning

  coverlet.console -> C:\git\coverlet\src\coverlet.console\bin\Debug\netcoreapp2.2\coverlet.console.dll
  Successfully created package 'C:\git\coverlet\bin\Debug\Packages\coverlet.collector.1.1.52-g15a6388dd8.nupkg'.
C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5127: This package does not contain a lib/ or ref/ folder, and will therefore be treated as compatible for all frameworks. Since framework specific files were found under the build/ directory for netstandard1.0, consider creating the following empty files to correctly narrow the compatibility of the package: [C:\git\coverlet\src\coverlet.collector\coverlet.collector.csproj]
C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5127: -lib/netstandard1.0/_._ [C:\git\coverlet\src\coverlet.collector\coverlet.collector.csproj]
  Successfully created package 'C:\git\coverlet\bin\Debug\Packages\coverlet.collector.1.1.52-g15a6388dd8.snupkg'.
  Successfully created package 'C:\g

I've opened an issue on nuget repo seems a bug NuGet/Home#8941

cc: @tonerdo @petli

@MarcoRossignoli MarcoRossignoli added enhancement General enhancement request infrastructure labels Jan 13, 2020
@MarcoRossignoli MarcoRossignoli requested a review from petli January 13, 2020 13:58
eng/build.yml Outdated
- task: DotNetCoreCLI@2
displayName: Test
inputs:
command: test
arguments: -c $(BuildConfiguration) --no-build /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:Include=[coverlet.*]* /p:Exclude=[coverlet.tests.remoteexecutor]*
testRunTitle: $(Agent.JobName)

- script: dotnet pack -c $(BuildConfiguration)
Copy link
Collaborator Author

@MarcoRossignoli MarcoRossignoli Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/sdk#3001 new behaviour I think that pack will build core project, not a great issue pack is pretty fast.

@MarcoRossignoli MarcoRossignoli changed the title Move/Pin to 3.1 runtime [WIP]Move/Pin to 3.1 runtime Jan 13, 2020
@@ -1,7 +1,12 @@
steps:
- task: UseDotNet@2
inputs:
version: 2.2.402
version: 2.2.207
Copy link
Collaborator Author

@MarcoRossignoli MarcoRossignoli Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have some integration tests done with netcoreapp2.1;netcoreapp2.2 and roll forward major is not supported by default https://github.com/dotnet/designs/blob/master/accepted/runtime-binding.md

@MarcoRossignoli MarcoRossignoli changed the title [WIP]Move/Pin to 3.1 runtime Move/Pin to 3.1 runtime Jan 13, 2020
@MarcoRossignoli
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli
Copy link
Collaborator Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@MarcoRossignoli MarcoRossignoli merged commit caac526 into coverlet-coverage:master Jan 14, 2020
@MarcoRossignoli MarcoRossignoli deleted the pin3.1 branch January 14, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement request infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant