[Bug fix] Put the same code that is in covelet.console to show the same result in 'average' (tonerdo#346) #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dules.2 (tonerdo#346)
…me result in 'average' (tonerdo#346)
MarcoRossignoli
approved these changes
Aug 3, 2019
|
For reference: |
|
@dlplenin Diego can you try tomorrow and confirm correct output please? |
Monday for sure! Now I dont have my computer with me, sorry. |
|
Oh yes I mean "tomorrow" we'll have new nightly...when you can 😄 |
|
@MarcoRossignoli Running a docker compose: |
|
Thank's to you for help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MarcoRossignoli
Average calculation: This PR is related with #479
Today I installed a nightly build of coverlet.msbuild and I realized that a piece of code in coverlet.msbuild.tasks was not taken into account in the previous PR, to keep consistency.