Skip to content

Conversation

MarcoRossignoli
Copy link
Collaborator

Fixes #315

New output

<?xml version="1.0" encoding="utf-8"?>
<CoverageSession>
  <Summary numSequencePoints="3" visitedSequencePoints="1" numBranchPoints="4" visitedBranchPoints="1" sequenceCoverage="33.3" branchCoverage="25" maxCyclomaticComplexity="4" minCyclomaticComplexity="4" visitedClasses="1" numClasses="1" visitedMethods="1" numMethods="1" />
  <Modules>
    <Module hash="E04CA10A-958D-4B1C-AB12-7833BBACF011">
      <ModulePath>Coverlet.Core.Reporters.Tests</ModulePath>
      <ModuleTime>2019-01-30T09:22:19</ModuleTime>
      <ModuleName>Coverlet.Core.Reporters</ModuleName>
      <Files>
        <File uid="1" fullPath="doc.cs" />
      </Files>
      <Classes>
        <Class>
          <Summary numSequencePoints="3" visitedSequencePoints="1" numBranchPoints="4" visitedBranchPoints="1" sequenceCoverage="33.3" branchCoverage="25" maxCyclomaticComplexity="4" minCyclomaticComplexity="4" visitedClasses="1" numClasses="1" visitedMethods="1" numMethods="1" />
          <FullName>Coverlet.Core.Reporters.Tests.OpenCoverReporterTests</FullName>
          <Methods>
            <Method cyclomaticComplexity="4" nPathComplexity="0" sequenceCoverage="33.3" branchCoverage="25" isConstructor="False" isGetter="False" isSetter="False" isStatic="True">
              <Summary numSequencePoints="3" visitedSequencePoints="1" numBranchPoints="4" visitedBranchPoints="1" sequenceCoverage="33.3" branchCoverage="25" maxCyclomaticComplexity="4" minCyclomaticComplexity="4" visitedClasses="0" numClasses="0" visitedMethods="1" numMethods="1" />
              <MetadataToken />
              <Name>System.Void Coverlet.Core.Reporters.Tests.OpenCoverReporterTests.TestReport()</Name>
              <FileRef uid="1" />
              <SequencePoints>
                <SequencePoint vc="1" uspid="1" ordinal="0" sl="1" sc="1" el="1" ec="2" bec="0" bev="0" fileid="1" />
                <SequencePoint vc="0" uspid="2" ordinal="1" sl="2" sc="1" el="2" ec="2" bec="0" bev="0" fileid="1" />
                <SequencePoint vc="0" uspid="3" ordinal="2" sl="3" sc="1" el="3" ec="2" bec="0" bev="0" fileid="1" />
              </SequencePoints>
              <BranchPoints>
                <BranchPoint vc="1" uspid="1" ordinal="1" path="0" offset="23" offsetend="24" sl="1" fileid="1" />
                <BranchPoint vc="0" uspid="1" ordinal="2" path="1" offset="23" offsetend="27" sl="1" fileid="1" />
                <BranchPoint vc="0" uspid="1" ordinal="3" path="0" offset="40" offsetend="41" sl="1" fileid="1" />
                <BranchPoint vc="0" uspid="1" ordinal="4" path="1" offset="40" offsetend="44" sl="1" fileid="1" />
              </BranchPoints>
              <MethodPoint vc="1" uspid="0" p8:type="SequencePoint" ordinal="0" offset="0" sc="0" sl="1" ec="1" el="3" bec="0" bev="0" fileid="1" xmlns:p8="xsi" />
            </Method>
          </Methods>
        </Class>
      </Classes>
    </Module>
  </Modules>
</CoverageSession>

/cc @tonerdo @charlieschmidt

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files          16       16           
  Lines        2011     2011           
=======================================
  Hits         1741     1741           
  Misses        270      270

Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I please see the output without this change? Thanks!

@MarcoRossignoli
Copy link
Collaborator Author

Sure

<?xml version="1.0" encoding="utf-8"?>
<CoverageSession>
  <Summary numSequencePoints="2" visitedSequencePoints="1" numBranchPoints="2" visitedBranchPoints="1" sequenceCoverage="0,5" branchCoverage="0,5" maxCyclomaticComplexity="2" minCyclomaticComplexity="2" visitedClasses="1" numClasses="1" visitedMethods="1" numMethods="1" />
  <Modules>
    <Module hash="AEB2161A-D00C-48B0-AF7C-C17F4C09E5D0">
      <ModulePath>Coverlet.Core.Reporters.Tests</ModulePath>
      <ModuleTime>2019-01-31T03:19:08</ModuleTime>
      <ModuleName>Coverlet.Core.Reporters</ModuleName>
      <Files>
        <File uid="1" fullPath="doc.cs" />
      </Files>
      <Classes>
        <Class>
          <Summary numSequencePoints="2" visitedSequencePoints="1" numBranchPoints="2" visitedBranchPoints="1" sequenceCoverage="0,5" branchCoverage="0,5" maxCyclomaticComplexity="2" minCyclomaticComplexity="2" visitedClasses="1" numClasses="1" visitedMethods="1" numMethods="1" />
          <FullName>Coverlet.Core.Reporters.Tests.OpenCoverReporterTests</FullName>
          <Methods>
            <Method cyclomaticComplexity="2" nPathComplexity="0" sequenceCoverage="0,5" branchCoverage="0,5" isConstructor="False" isGetter="False" isSetter="False" isStatic="True">
              <Summary numSequencePoints="2" visitedSequencePoints="1" numBranchPoints="2" visitedBranchPoints="1" sequenceCoverage="0,5" branchCoverage="0,5" maxCyclomaticComplexity="2" minCyclomaticComplexity="2" visitedClasses="0" numClasses="0" visitedMethods="1" numMethods="1" />
              <MetadataToken />
              <Name>System.Void Coverlet.Core.Reporters.Tests.OpenCoverReporterTests.TestReport()</Name>
              <FileRef uid="1" />
              <SequencePoints>
                <SequencePoint vc="1" uspid="1" ordinal="0" sl="1" sc="1" el="1" ec="2" bec="0" bev="0" fileid="1" />
                <SequencePoint vc="0" uspid="2" ordinal="1" sl="2" sc="1" el="2" ec="2" bec="0" bev="0" fileid="1" />
              </SequencePoints>
              <BranchPoints>
                <BranchPoint vc="1" uspid="1" ordinal="1" path="0" offset="23" offsetend="24" sl="1" fileid="1" />
                <BranchPoint vc="0" uspid="1" ordinal="2" path="1" offset="23" offsetend="27" sl="1" fileid="1" />
              </BranchPoints>
              <MethodPoint vc="1" uspid="0" p8:type="SequencePoint" ordinal="0" offset="0" sc="0" sl="1" ec="1" el="2" bec="0" bev="0" fileid="1" xmlns:p8="xsi" />
            </Method>
          </Methods>
        </Class>
      </Classes>
    </Module>
  </Modules>
</CoverageSession>

Numbers are different because to have better test I added branches/line, to verify I used OpenCover sample file https://github.com/OpenCover/opencover/blob/master/samplexml/opencovertests.xml#L151

@tonerdo tonerdo merged commit 38a2104 into coverlet-coverage:master Feb 4, 2019
@MarcoRossignoli MarcoRossignoli deleted the fixopencoverreportbug branch February 13, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants