Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard instrumentation exclude Interlocked #302

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

ViktorHofer
Copy link
Contributor

Excluding System.Threading.Interlocked from instrumentation which is used for recording hits. Not excluding that type would cause an infinite loop as it would call itself.

cc @sharwell @tonerdo

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #302 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   89.06%   89.08%   +0.01%     
==========================================
  Files          16       16              
  Lines        1912     1915       +3     
==========================================
+ Hits         1703     1706       +3     
  Misses        209      209
Impacted Files Coverage Δ
src/coverlet.core/Instrumentation/Instrumenter.cs 99.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63dff09...f68473b. Read the comment docs.

@ViktorHofer
Copy link
Contributor Author

ViktorHofer commented Jan 16, 2019

@tonerdo it would be great if we could release a new package with this change and #276 to unblock us in corefx and dotnet/machinelearning.

@tonerdo tonerdo merged commit 7feb550 into coverlet-coverage:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants