-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
226 teamcity support #227
226 teamcity support #227
Conversation
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 94.91% 95.27% +0.35%
==========================================
Files 15 16 +1
Lines 1633 1693 +60
==========================================
+ Hits 1550 1613 +63
+ Misses 83 80 -3
Continue to review full report at Codecov.
|
Is there anyway this can be achieved by simply creating a new reporter? Even if it means re-designing the |
Yeah I can do that |
It's gonna look a little wonky since we have to pass an action to log, and return an empty string to write out to a file. |
Nevermind, I added a boolean to all reporters indicating if their output should be written to the console or a file. Turned out less jank than I expected |
@tonerdo do you care about the drop in coverage? Do I have to do anything else to get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Modulo the comments
Not particularly. This is ready to be merged once you address comments |
Thank you! |
As discussed on #226, this will enable statistics in TeamCity by utilizing TeamCity service Messages.
The currently supported TeamCity statistics are: