Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

226 teamcity support #227

Merged
merged 8 commits into from
Nov 13, 2018
Merged

226 teamcity support #227

merged 8 commits into from
Nov 13, 2018

Conversation

Reptarsrage
Copy link
Contributor

As discussed on #226, this will enable statistics in TeamCity by utilizing TeamCity service Messages.

The currently supported TeamCity statistics are:

TeamCity Statistic Key Description
CodeCoverageL Line-level code coverage
CodeCoverageC Class-level code coverage
CodeCoverageM Method-level code coverage
CodeCoverageAbsLTotal The total number of lines
CodeCoverageAbsLCovered The number of covered lines
CodeCoverageAbsCTotal The total number of classes
CodeCoverageAbsCCovered The number of covered classes
CodeCoverageAbsMTotal The total number of methods
CodeCoverageAbsMCovered The number of covered methods

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #227 into master will increase coverage by 0.35%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   94.91%   95.27%   +0.35%     
==========================================
  Files          15       16       +1     
  Lines        1633     1693      +60     
==========================================
+ Hits         1550     1613      +63     
+ Misses         83       80       -3
Impacted Files Coverage Δ
src/coverlet.core/Reporters/CoberturaReporter.cs 98.55% <0%> (-0.72%) ⬇️
src/coverlet.core/Reporters/OpenCoverReporter.cs 99.11% <0%> (-0.44%) ⬇️
src/coverlet.core/Reporters/JsonReporter.cs 50% <0%> (-16.67%) ⬇️
src/coverlet.core/Reporters/LcovReporter.cs 96% <0%> (-1.96%) ⬇️
src/coverlet.core/Reporters/TeamCityReporter.cs 100% <100%> (ø)
src/coverlet.core/Reporters/ReporterFactory.cs 100% <100%> (ø) ⬆️
src/coverlet.core/CoverageSummary.cs 99.14% <0%> (+6.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54c93c...fbd01ad. Read the comment docs.

@tonerdo
Copy link
Collaborator

tonerdo commented Nov 4, 2018

Is there anyway this can be achieved by simply creating a new reporter? Even if it means re-designing the IReporter interface to be more flexible. Adding a whole new option just for a single CI service seems quite odd

@Reptarsrage
Copy link
Contributor Author

Yeah I can do that

@obtuse-whoosh
Copy link
Contributor

It's gonna look a little wonky since we have to pass an action to log, and return an empty string to write out to a file.

@obtuse-whoosh
Copy link
Contributor

Nevermind, I added a boolean to all reporters indicating if their output should be written to the console or a file. Turned out less jank than I expected

@Reptarsrage
Copy link
Contributor Author

@tonerdo do you care about the drop in coverage? Do I have to do anything else to get this merged?

Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Modulo the comments

@tonerdo
Copy link
Collaborator

tonerdo commented Nov 13, 2018

do you care about the drop in coverage?

Not particularly. This is ready to be merged once you address comments

@tonerdo
Copy link
Collaborator

tonerdo commented Nov 13, 2018

Thank you!

@tonerdo tonerdo merged commit 7ede9d7 into coverlet-coverage:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants