-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of ExcludeFromCodeCoverage attribute #112
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 48 additions & 6 deletions
54
test/coverlet.core.tests/Instrumentation/InstrumenterTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,75 @@ | ||
| using System; | ||
| using System.IO; | ||
|
|
||
| using System.Linq; | ||
| using Xunit; | ||
| using Coverlet.Core.Instrumentation; | ||
| using Coverlet.Core.Samples.Tests; | ||
|
|
||
| namespace Coverlet.Core.Instrumentation.Tests | ||
| { | ||
| public class InstrumenterTests | ||
| { | ||
| [Fact] | ||
| public void TestInstrument() | ||
| { | ||
| var instrumenterTest = CreateInstrumentor(); | ||
|
|
||
| var result = instrumenterTest.Instrumenter.Instrument(); | ||
|
|
||
| Assert.Equal(Path.GetFileNameWithoutExtension(instrumenterTest.Module), result.Module); | ||
| Assert.Equal(instrumenterTest.Module, result.ModulePath); | ||
|
|
||
| instrumenterTest.Directory.Delete(true); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(typeof(ClassExcludedByCodeAnalysisCodeCoverageAttr))] | ||
| [InlineData(typeof(ClassExcludedByCoverletCodeCoverageAttr))] | ||
| public void TestInstrument_ClassesWithExcludeAttributeAreExcluded(Type excludedType) | ||
| { | ||
| var instrumenterTest = CreateInstrumentor(); | ||
| var result = instrumenterTest.Instrumenter.Instrument(); | ||
|
|
||
| var doc = result.Documents.FirstOrDefault(d => Path.GetFileName(d.Path) == "Samples.cs"); | ||
| Assert.NotNull(doc); | ||
|
|
||
| var found = doc.Lines.Any(l => l.Class == excludedType.FullName); | ||
| Assert.False(found, "Class decorated with with exclude attribute should be excluded"); | ||
|
|
||
| instrumenterTest.Directory.Delete(true); | ||
| } | ||
|
|
||
| private InstrumenterTest CreateInstrumentor() | ||
| { | ||
| string module = GetType().Assembly.Location; | ||
| string pdb = Path.Combine(Path.GetDirectoryName(module), Path.GetFileNameWithoutExtension(module) + ".pdb"); | ||
| string identifier = Guid.NewGuid().ToString(); | ||
|
|
||
| var directory = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), identifier)); | ||
| DirectoryInfo directory = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), identifier)); | ||
|
|
||
| File.Copy(module, Path.Combine(directory.FullName, Path.GetFileName(module)), true); | ||
| File.Copy(pdb, Path.Combine(directory.FullName, Path.GetFileName(pdb)), true); | ||
|
|
||
| module = Path.Combine(directory.FullName, Path.GetFileName(module)); | ||
| Instrumenter instrumenter = new Instrumenter(module, identifier, Array.Empty<string>(), Array.Empty<string>()); | ||
| var result = instrumenter.Instrument(); | ||
| return new InstrumenterTest | ||
| { | ||
| Instrumenter = instrumenter, | ||
| Module = module, | ||
| Identifier = identifier, | ||
| Directory = directory | ||
| }; | ||
| } | ||
|
|
||
| class InstrumenterTest | ||
| { | ||
| public Instrumenter Instrumenter { get; set; } | ||
|
|
||
| public string Module { get; set; } | ||
|
|
||
| Assert.Equal(Path.GetFileNameWithoutExtension(module), result.Module); | ||
| Assert.Equal(module, result.ModulePath); | ||
| public string Identifier { get; set; } | ||
|
|
||
| directory.Delete(true); | ||
| public DirectoryInfo Directory { get; set; } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't think we need this as a field. A local variable is just fine