Skip to content

We should avoid "standard" switch name for msbuild driver #580

Closed
@MarcoRossignoli

Description

@MarcoRossignoli

Usually I work with a VS command prompt.
Doing some test I found that "strange" include filter are present

C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.24.28117\ATLMFC\include;C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.24.28117\include;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt

I've opened an issue on cli repo https://github.com/dotnet/cli/issues/12821
At the end the issue is the name switch Include that is used by vs command line env and used by msbuild.

I think that we should avoid to have name that collide with "standard" switch name, for instance we should prepend every switch with "Coverlet" i.e.

λ dotnet test --filter "TestCategory!=FailureExpected" -v:m /p:CoverletCollectCoverage=true /p:CoverletInclude=....

It's a breaking change.

cc: @tonerdo @petli

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking-changeIssue or PR that represents a breaking change in features or functional.driver-msbuildIssue related to msbuild driver

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions