Skip to content

Conversation

@ryanmab
Copy link
Member

@ryanmab ryanmab commented Nov 11, 2025

Description

@github-actions github-actions bot added the feature Pull requests that implement a new feature (for releases) label Nov 11, 2025
@ryanmab ryanmab added the bump-patch Pull request which needs to bump a patch version in this repository. label Nov 11, 2025
@coverage-robot
Copy link

coverage-robot bot commented Nov 11, 2025

Coverage Report

Merging #2447 will decrease the total coverage by 0.24% (compared to 954bb92)

Warning

Consider additional tests: There's 50 lines that are new and not tested!

Total Coverage Diff Coverage
78.11% 64.29%
Tags
Tag Lines Covered Partial Uncovered Coverage
analyse-service
(Carried forward from 954bb92)
2430 2124 0 306 87.41%
api-service
(Carried forward from 954bb92)
1418 1013 0 405 71.44%
clients-package
(Carried forward from ad3229f)
95 88 0 7 92.63%
configuration-package
(Carried forward from ad3229f)
665 513 0 152 77.14%
event-package
(Carried forward from ad3229f)
166 107 0 59 64.46%
ingest-service 1010 839 0 171 83.07%
local-package
(Carried forward from ad3229f)
251 170 0 81 67.73%
message-package
(Carried forward from ad3229f)
92 56 0 36 60.87%
orchestrator-service
(Carried forward from 954bb92)
846 700 0 146 82.74%
publish-service
(Carried forward from 954bb92)
1116 718 0 398 64.34%
telemetry-package
(Carried forward from ad3229f)
108 75 0 33 69.44%
Impacted Files
File Diff Coverage
services/ingest/src/Strategy/GoCover/GoCoverParseStrategy.php 64.29%

Last update to 4a64bbc at 00:30am UTC

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Terraform plan in ./services/ingest/infrastructure in the prod workspace
With var files: ./services/ingest/infrastructure/prod.tfvars

Plan: 0 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # module.ingest.aws_lambda_function.service will be updated in-place
!~  resource "aws_lambda_function" "service" {
        id                             = "coverage-ingest-prod"
!~      last_modified                  = "2025-11-11T21:51:18.000+0000" -> (known after apply)
!~      source_code_hash               = "JrCZl5WkV2uy8Xu/KczdRUVNlniX1bdBro8ejWl0enc=" -> "l4/eqnoAAzyspWIne5UbNGAh/Ab7vIjNNaJ0SX8YTpo="
        tags                           = {}
#        (29 unchanged attributes hidden)

#        (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

✅ Plan applied in Ingest #2477

@ryanmab ryanmab marked this pull request as ready for review November 12, 2025 00:14
CoverageFormat::GO_COVER,
root: $projectRoot,
);
} catch (Exception $exception) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next 10 lines are not covered by any tests.

$block
);
}
} catch (LogicException $logicException) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next 9 lines are not covered by any tests.


// Skip empty lines
if ($line === '') {
return $coverage;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not covered by any tests.


// Match the record type and its data
if (preg_match(self::LINE_STRUCTURE, $line, $parts) !== 1) {
throw new ParseException(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next 5 lines are not covered by any tests.

}

if ($startLine > $endLine) {
$this->parseStrategyLogger->error(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next 22 lines are not covered by any tests.

@ryanmab ryanmab merged commit fbd7c9a into main Nov 12, 2025
10 checks passed
@ryanmab ryanmab deleted the feature/add-go-cover-parsing-support branch November 12, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump-patch Pull request which needs to bump a patch version in this repository. feature Pull requests that implement a new feature (for releases)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants