fix: enableQuerySyntax is not passed to recent-query-list controller
#3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
commented
Apr 18, 2024
packages/headless/src/controllers/recent-queries-list/headless-recent-queries-list.test.ts
Show resolved
Hide resolved
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support |
louis-bompart
approved these changes
Apr 18, 2024
fbeaudoincoveo
approved these changes
Apr 18, 2024
packages/headless/src/controllers/recent-queries-list/headless-recent-queries-list.test.ts
Outdated
Show resolved
Hide resolved
packages/headless/src/controllers/recent-queries-list/headless-recent-queries-list.ts
Outdated
Show resolved
Hide resolved
olamothe
approved these changes
Apr 19, 2024
…-recent-queries-list.test.ts Co-authored-by: Frederic Beaudoin <fbeaudoin@coveo.com>
fpbrault
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3096
Whenever a submit action (Enter key pressed) is being recorded on a recent-query suggestion, the
prepareForSearchWithQuerysearch action is triggered with the appropriateenableQuerySyntaxvalue.However, when a mouse click action is recorded on a recent-query suggestion, the
prepareForSearchWithQuerysearch action called by the headless-recent-queries-list controller does not specify theenableQuerySyntaxvalue.