-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Francois's post about WSL and Dockerfiles #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool article, fun read! A couple of minor suggestions, no major issue.
I'd say that fixing typos and improving the excerpt are the only change I would insist on :)
:gg:
Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com>
Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com>
Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com>
Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com>
Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com>
Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com>
Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some minor comments :gg:
Thanks to all the reviewers! |
* fix or remove broken links (coveo#203) * Francois's post about WSL and Dockerfiles (coveo#204) * First version of my first blog post * Fix for liquid syntax and curly braces * Remove syntax highligthing. * Fix typo * Update _posts/2019-10-18-wsl-from-dockerfile.md Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com> * Update _posts/2019-10-18-wsl-from-dockerfile.md Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com> * Update _posts/2019-10-18-wsl-from-dockerfile.md Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com> * Update _posts/2019-10-18-wsl-from-dockerfile.md Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com> * Update _posts/2019-10-18-wsl-from-dockerfile.md Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com> * Fix typo again, and add link to Go Template * Update _posts/2019-10-18-wsl-from-dockerfile.md Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com> * Update _posts/2019-10-18-wsl-from-dockerfile.md Co-Authored-By: Francois Lachance-Guillemette <francois.lguillemette@gmail.com> * Moved one paragraph into the excerpt. * Text review suggestions from amoreau * Change unordered to ordered list for steps in env vars * 5 reasons why you're not reaching full relevance-BlogPost (coveo#205) * Add files via upload * Add files via upload * Delete goldenticket.gif * Add files via upload * Create 2019-11-20-5-reasons-why-you're-not-reaching-full-relevancy.md * Update 2019-11-20-5-reasons-why-you're-not-reaching-full-relevancy.md * Update 2019-11-20-5-reasons-why-you're-not-reaching-full-relevancy.md * Update 2019-11-20-5-reasons-why-you're-not-reaching-full-relevancy.md * Update 2019-11-20-5-reasons-why-you're-not-reaching-full-relevancy.md * Rename 2019-11-20-5-reasons-why-you're-not-reaching-full-relevancy.md to 2019-11-21-5-reasons-why-you're-not-reaching-full-relevance.md Co-authored-by: Francois Rivard <30326057+RoguePointer80@users.noreply.github.com> Co-authored-by: ariouxcoveo <53542026+ariouxcoveo@users.noreply.github.com>
Please merge into the main branch my post about WSL and Dockerfiles