Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link in results-manager template #1313

Merged

Conversation

mrrajamanickam-coveo
Copy link
Contributor

@mrrajamanickam-coveo mrrajamanickam-coveo commented May 10, 2023

Proposed changes

  • fix broken link in results-manager template

@mrrajamanickam-coveo mrrajamanickam-coveo requested a review from a team as a code owner May 10, 2023 21:30
@mrrajamanickam-coveo mrrajamanickam-coveo requested review from olamothe, y-lakhdar and louis-bompart and removed request for a team May 10, 2023 21:30
@github-actions
Copy link
Contributor

Thanks for your contribution @mrrajamanickam-coveo !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@mrrajamanickam-coveo
Copy link
Contributor Author

mrrajamanickam-coveo commented Aug 18, 2023

Don't think the changes in this PR updating a doc string should cause the CI error

 › 3 snapshots failed.
Snapshot Summary
 › 3 snapshots failed from 1 test suite. Inspect your code changes or run `npm run jest:ci -- -u` to update them.

Shall I proceed to merge @louis-bompart ?

@louis-bompart
Copy link
Collaborator

Don't think the changes in this PR updating a doc string should cause the CI error

 › 3 snapshots failed.
Snapshot Summary
 › 3 snapshots failed from 1 test suite. Inspect your code changes or run `npm run jest:ci -- -u` to update them.

Shall I proceed to merge @louis-bompart ?

Lgtm.
If you have time, stabilize snaps on main before. If not, no biggie.
Cause: release should update snaps, they don't.

@mrrajamanickam-coveo
Copy link
Contributor Author

Not sure what updating snapshots means in the context of CI. Is it jest snapshots? Tried to follow the instruction "run npm run jest:ci -- -u to update them" from the test failure but jest:ci doesn't exist in pkg json - couldn't find any equivalent in pkg json either.

Will merge this in the interest of getting the long open PR closed.

@mrrajamanickam-coveo mrrajamanickam-coveo enabled auto-merge (squash) August 19, 2023 00:44
@mrrajamanickam-coveo mrrajamanickam-coveo merged commit 0f3bd2d into master Aug 19, 2023
25 of 32 checks passed
@mrrajamanickam-coveo mrrajamanickam-coveo deleted the mrrajamanickam-coveo-fix-link-result-manager branch August 19, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants