Introduce publication #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output is now: ``` openjdk version "18.0.1" 2022-04-19 OpenJDK Runtime Environment Zulu18.30+11-CA (build 18.0.1+10) OpenJDK 64-Bit Server VM Zulu18.30+11-CA (build 18.0.1+10, mixed mode, sharing) ```
Contributor
Author
|
with your approval, I think this PR will be green @alexarchambault |
Member
alexarchambault
left a comment
alexarchambault
left a comment
There was a problem hiding this comment.
Thanks @daddykotex! I only left minor comments.
Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com>
This reverts commit 3ff68a5.
Contributor
Author
|
should be ready to go |
Contributor
Author
|
bumping so you can trigger a build so I can any remaining issue |
Conflicts: interface-test/src/test/java/coursierapi/test/JvmManagerTests.java interface/src/main/scala/coursier/internal/api/ApiHelper.scala
alexarchambault
approved these changes
Jul 11, 2022
Member
alexarchambault
left a comment
alexarchambault
left a comment
There was a problem hiding this comment.
Merging, thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There!
I finally ran the tests (some weird sbt-junit-interface issue)...
Anyway the output of jvm 18 was a tidy bit different being 18.0.1