used more precise login endpoints #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you're on it, do you think you could also take a look at #573? |
|
@balta2ar Ok, I'll look into it later this week. |
|
@balta2ar Hi. I've amended this PR, so login will work on other openedx sites (ones that received no change to the login process). This fixes #573 (fun-mooc.fr). Note, however that this is somewhat nominal fix, as it seems that downloading video from fun-mooc.fr is broken in it's own way. I've tried couple of courses and only resources were downloaded (not video). It looks to me that the problem is either because FUN does not host videos on youtube or something is broken with parsing FUN course pages. Anyway, this is just a guess as I am not willing to tackle this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@balta2ar Thank you for merging #569
Based on troubleshooting from #559 there is small tweak to login endpoints that should be made in order to fix the problem for all users. This PR addresses this.