Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AcuRite 986 Refrigrerator / Freezer Temperature sensors #43

Merged
merged 6 commits into from
Jan 2, 2021

Conversation

NorthernMan54
Copy link

@NorthernMan54 NorthernMan54 commented Jan 1, 2021

This is just a trial pull request, before submitting a final one. I still need to validate low battery before submitting the final, but wanted to send an early draft incase I followed an incorrect approach around adding support for another sensor type. I have a motion sensor that I'm about to add as well

Changes include

  • Support for AcuRite 986 Refrigrerator / Freezer Temperature sensors ( Borrowed a lot of the decode logic from rtf_443 ). Coded this as plugin 37.
  • Fixes for the Alectov devices to move the duplicate message check later in Plugin 30/32 as the duplicate check was colliding for Plugin 32 and caused messages for Plugin 32 to be dropped. ( I have one of these )
  • Plugin 32, made some minor tweaks and include battery support. The ID field no longer contains the button press BIT or Battery bit as I found it was changing the ID when the battery was low or the test button was pressed.

Sean Gracey and others added 6 commits December 31, 2020 12:19
Added support for battery on Plugin_32 and moved the duplicate check
later for Plugin30 and Plugin32.   The duplicate check was failing
Working, but with debug.   Battery testing is outstanding
@couin3 couin3 self-requested a review January 2, 2021 12:48
@couin3 couin3 merged commit df15fef into couin3:master Jan 2, 2021
@NorthernMan54
Copy link
Author

Tks for merging this but it has a couple of changes that you may not want to include

1 - ArduinoOTA
2 - 6_Credentials.h is removed
3 - default serial speed changed to 921600
4 - default pin changed to #define PIN_RF_RX_DATA_0 D1

@couin3
Copy link
Owner

couin3 commented Jan 2, 2021

True! I already changed 1 and 2, and will also get 3 and 4 back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants