CBG-3605 fix test flake: wait for stat

[torcolvin]

CBG-3605 fix test flake: wait for stat

This flake is reproducible with adding a sleep here

sync_gateway/db/active_replicator_checkpointer.go

Line 197 in 14787f7

[Copilot]

Pull request overview

This PR addresses test flakiness in TestActiveReplicatorPullBasic where the test was asserting the replication status immediately after a document write, leading to occasional failures due to a race condition between document persistence and status updates.

Changes:

• Replaced immediate assertion with an eventually-consistent wait pattern to handle timing variance between document write and status update

[Copilot]

The timeout (5 seconds) and poll interval (10 milliseconds) should be defined as named constants rather than magic numbers. This improves maintainability and makes it easier to adjust timing parameters consistently across tests.

Suggested change

	require.EventuallyWithT(t, func(c *assert.CollectT) {
	status := ar.GetStatus(ctx1)
	assert.Equal(c, strconv.FormatUint(remoteDoc.Sequence, 10), status.LastSeqPull, "status=%#+v", status)
	}, 5*time.Second, 10*time.Millisecond)
	const (
	// These constants control how long we wait, and how often we poll, for the replicator status to reflect
	// the sequence of the last pulled document.
	replicatorStatusTimeout = 5 * time.Second
	replicatorStatusPollInterval = 10 * time.Millisecond
	)
	require.EventuallyWithT(t, func(c *assert.CollectT) {
	status := ar.GetStatus(ctx1)
	assert.Equal(c, strconv.FormatUint(remoteDoc.Sequence, 10), status.LastSeqPull, "status=%#+v", status)
	}, replicatorStatusTimeout, replicatorStatusPollInterval)