-
Notifications
You must be signed in to change notification settings - Fork 92
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MB-43553: Conditionally closing Bucket's Pool instance
+ Close the Pool instance that the Bucket holds when the Bucket's connPools is cleared, ONLY when the Bucket instance is set up using either of these APIs .. - ConnectWithAuthAndGetBucket(..) - GetBucket(..) + This is to assist with closing the pool instance setup while initializing the bucket instance via the 2 APIs above. + To better facilitate the use case here - introducing a new internal API for client to setup a pool only for the requested bucket and not all the buckets in the system - which further reduces the amount of garbage. + Helps address the memory leak identified in the ticket. + `go fmt ./...` fixes formatting in an unrelated file. Change-Id: I6af32ff1e26dedcdaa62ffdff00c7e8c62bacc6f Reviewed-on: http://review.couchbase.org/c/go-couchbase/+/155752 Tested-by: Abhinav Dangeti <abhinav@couchbase.com> Reviewed-by: Sreekanth Sivasankaran <sreekanth.sivasankaran@couchbase.com>
- Loading branch information
1 parent
bba8776
commit b41ef93
Showing
2 changed files
with
75 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters