Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBD-5188: Add missing ports to docker run examples #192

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

udkyo
Copy link
Contributor

@udkyo udkyo commented Oct 27, 2022

We're missing various client-node ports, these should be included in our docker run examples to avoid confusion.

Copy link
Contributor

@ceejatec ceejatec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I would have changed all the old READMEs - a number of those new ports probably don't even apply to those versions of Server - but I'm honestly not sure they're used by anything anyway, so...

@udkyo udkyo merged commit 58efdaf into couchbase:master Nov 1, 2022
@udkyo
Copy link
Contributor Author

udkyo commented Nov 1, 2022

Yep, nothing uses them as far as I'm aware. Just force of habit on my part - we've been bitten by autobuilds overwriting the contents of the readme on the hub page with the readme from aged images which happened to be the most recently built, so I'm used to updating them all when changes need to be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants