Skip to content

RCBC-441: allow nil values for duration extractor #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023
Merged

RCBC-441: allow nil values for duration extractor #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/couchbase/utils/time.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ def extract_expiry_time(time_or_duration)
# then use it and convert result to Integer
# 3. Otherwise invoke #to_i on the argument and interpret it as a number of milliseconds
def extract_duration(number_or_duration)
return number_or_duration if number_or_duration.is_a? Integer
return unless number_or_duration
return number_or_duration if number_or_duration.class == Integer # rubocop:disable Style/ClassEqualityComparison avoid overrides of #is_a?, #kind_of?

if number_or_duration.respond_to?(:in_milliseconds)
number_or_duration.public_send(:in_milliseconds)
Expand Down
4 changes: 4 additions & 0 deletions test/utils_time_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,8 @@ def test_accepts_floats
def test_interpret_integer_as_a_milliseconds_literal
assert_equal 42, Couchbase::Utils::Time.extract_duration(42)
end

def test_ignores_nil_argument
assert_nil Couchbase::Utils::Time.extract_duration(nil)
end
end