Skip to content

PCBC-950: Support bucket settings for no dedup feature #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2023
Merged

PCBC-950: Support bucket settings for no dedup feature #131

merged 2 commits into from
Sep 19, 2023

Conversation

Matt-Woz
Copy link
Contributor

@Matt-Woz Matt-Woz commented Sep 8, 2023

Changes:

  • Implemented Bucket No dedup feature in collection and bucket manager
  • Deprecated old API for CreateCollection & DropCollection

@Matt-Woz Matt-Woz requested a review from avsej September 8, 2023 16:55
avsej
avsej reviewed Sep 11, 2023
View reviewed changes
avsej
avsej requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@avsej avsej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only one small note

@Matt-Woz Matt-Woz requested a review from avsej September 11, 2023 15:49
@Matt-Woz Matt-Woz merged commit d1bd39a into couchbase:main Sep 19, 2023
@Matt-Woz Matt-Woz deleted the PCBC-950_Support_bucket_no_dedup branch September 19, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt-Woz @avsej