Skip to content

PCBC-884 SDK Support for Native KV Range Scans #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 15, 2023
Merged

PCBC-884 SDK Support for Native KV Range Scans #122

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
825f416
Implement KVRS
Matt-Woz Aug 7, 2023
c5fdec8
remove comment
Matt-Woz Aug 7, 2023
2d4aa61
Lint and update package.xml
Matt-Woz Aug 7, 2023
bfdab48
Add ScanResult iterator
Matt-Woz Aug 8, 2023
3d3a573
Update package.xml
Matt-Woz Aug 8, 2023
7d8dcf8
Fix comments
Matt-Woz Aug 8, 2023
d42009b
Merge branch 'main' into PCBC-884_KVRS
avsej Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@Matt-Woz
Matt-Woz committed Aug 7, 2023
commit c5fdec8e60e575c604c7c3e5bb85225d6e551da8
2 changes: 1 addition & 1 deletion src/wrapper/connection_handle.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,7 +1723,7 @@ connection_handle::document_create_scan(zval* return_value,
agent_group.open_bucket(bucket_name);
auto agent = agent_group.get_agent(bucket_name);
if (!agent.has_value()) {
return { agent.error(), ERROR_LOCATION, "Cannot perform scan operation. Unable to get operation agent" }; //TODO: TEST THIS RETURNS CB EXCEPTION IF TRUE
return { agent.error(), ERROR_LOCATION, "Cannot perform scan operation. Unable to get operation agent" };
}

// Get vBucket map
Expand Down