CBL-5893: Throw exception for everything if finish() was successfully called beforehand #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use of updater after finish will throw exception
velicuvlad
changed the title
bmeike
approved these changes
Jul 3, 2024
|
@bmeike Spec was update last night so, in short yes. - Test 27. Also, as noted in test 27 description, itself and test 26 can be merged into a single on and this is what I've done in this PR. Now, it might be the case that I chose the wrong exception to throw, so I will be waiting for Pasin's review. |
|
Boy I hate these changes.... |
|
We had have a long discussion in Slack last week about this. It was a conclusion that we will make it illegal to use the index updater after calling finish. Sorry, I didn't have time to update the test spec after the discussion. For iOS, it's correct to throw NSInternalInconsistencyException. |
borrrden
approved these changes
Jul 3, 2024
pasin
added a commit
that referenced
this pull request
Jul 23, 2024
* CBL-5524 : Add all keys to the Privacy Manifest file (#3258) * CBL-5541 : Update vector search test per changes in v1.8 (#3260) * CBL-5365: Remove CBLErrors.h from Swift Public API (#3271) * CBL-5508: Update Min macOS Support Version to 12.0 (#3272) * CBL-5693 : Fix missing exported symbols (#3281) * CBL-5222: MutableDocument should be usable before creating a database instance (#3278) * CBL-5710: Add note that the replicator cannot be started in the inBatch() function (#3286) * CBL-5514: Swift MutableDocument's collection is not set when a new document is saved (#3287) * CBL-5660 : Fix a released query context may be used in observer callback (#3285) * CBL-5668: Get Code Coverage at least 80% (#3289) * CBL-3385: Allow null expression parameter for Function.count(expression) (#3290) * CBL-5750 + CBL-5757 Lazy Index - ObjC (#3291) * CBL-5811 : Support Vector Dimension to 4096 and Vector in Base64 String (#3294) * CBL-5803 : Implement Lazy Vector Index and Test for Swift (#3295) * CBL-5567 : Implement log replicator heiroglyphics (#3296) * CBL-5859 : Allow explicitly enable vector search (#3297) * CBL-5886: Add missing numProbes and correct min/maxTrainingSize default value (#3298) * CBL-5932: Update default constants and public symbols (#3299) * CBL-5928 : CBLErrors.h is not included in the umbrella header (#3301) * CBL-5927 : Fix Duplicate CBLQueryIndex Interface Definition (#3300) * CBL-5893: Throw exception for everything if finish() was successfully called beforehand (#3302) * CBL-5956: Update DistanceMetric (#3303) * CBL-5690 : Update Distance Metric Enum and VS SQL in Tests (#3304) * CBL-5990 : Fix _kCBLDefaultLogFileUsePlaintext symbol (#3305)
velicuvlad
added a commit
that referenced
this pull request
Nov 11, 2024
* CBL-5524 : Add all keys to the Privacy Manifest file (#3258) * CBL-5541 : Update vector search test per changes in v1.8 (#3260) * CBL-5365: Remove CBLErrors.h from Swift Public API (#3271) * CBL-5508: Update Min macOS Support Version to 12.0 (#3272) * CBL-5693 : Fix missing exported symbols (#3281) * CBL-5222: MutableDocument should be usable before creating a database instance (#3278) * CBL-5613: Swift API docs for Scope using Obj-c reference (#3284) * CBL-5710: Add note that the replicator cannot be started in the inBatch() function (#3286) * CBL-5514: Swift MutableDocument's collection is not set when a new document is saved (#3287) * CBL-5660 : Fix a released query context may be used in observer callback (#3285) * CBL-5668: Get Code Coverage at least 80% (#3289) * CBL-3385: Allow null expression parameter for Function.count(expression) (#3290) * CBL-5750 + CBL-5757 Lazy Index - ObjC (#3291) * CBL-5811 : Support Vector Dimension to 4096 and Vector in Base64 String (#3294) * CBL-5803 : Implement Lazy Vector Index and Test for Swift (#3295) * CBL-5567 : Implement log replicator heiroglyphics (#3296) * CBL-5859 : Allow explicitly enable vector search (#3297) * CBL-5886: Add missing numProbes and correct min/maxTrainingSize default value (#3298) * CBL-5932: Update default constants and public symbols (#3299) * CBL-5928 : CBLErrors.h is not included in the umbrella header (#3301) * CBL-5927 : Fix Duplicate CBLQueryIndex Interface Definition (#3300) * CBL-5893: Throw exception for everything if finish() was successfully called beforehand (#3302) * CBL-5956: Update DistanceMetric (#3303) * CBL-5690 : Update Distance Metric Enum and VS SQL in Tests (#3304) * CBL-5990 : Fix _kCBLDefaultLogFileUsePlaintext symbol (#3305) * CBL-6070: Implement Database Full-Sync Option (#3318) * CBL-6144: Add testConcurrentCreateAndQuery to verify query's lock (#3320) * CBL-6191 : Fix null URL for proxy CONNECT request (#3324) * CBL-5180: Implement Array Index API (#3327) * CBL-5181: Array Index API tests and adjustments (#3330) * CBL-5899 * CBL-6307: Database MMap Configuration API and tests (#3333) * CBL-6349: Implement Document's getRevisionHistory() for E2E Test Server (#3335) * LiteCore 3.2.1-19 * Export symbol for mmap constant (#3341) * ArrayIndexConfiguration explicit expressions arg on set (#3342) --------- Co-authored-by: Pasin Suriyentrakorn <pasin@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
count(),valueAtIndex(),setVector(),skipVector()andfinish()will throw an NSException if the updater is already finished.