last fixes

couchbase · Nov 14, 2024 · 2b1a872 · 2b1a872
1 parent e8e5363
commit 2b1a872
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 21 deletions.
diff --git a/Objective-C/CBLDocument.mm b/Objective-C/CBLDocument.mm
@@ -201,12 +201,16 @@ - (void) replaceC4Doc: (CBLC4Document*)c4doc {
 }
 
 - (nullable NSString*) _getRevisionHistory {
+    if (!_collection) {
+        return nil;
+    }
+
     CBL_LOCK(self) {
-        if (!_c4Doc) {
-            return nil;
-        } else {
-            return sliceResult2string(c4doc_getRevisionHistory(_c4Doc.rawDoc, UINT_MAX, nil, 0));
-        }
+        C4Error err;
+        C4Document* doc = c4coll_getDoc(_collection.c4col, _c4Doc.docID, true, kDocGetAll, &err);
+        NSString* revHistory = doc ? sliceResult2string(c4doc_getRevisionHistory(doc, UINT_MAX, nil, 0)) : nil;
+        c4doc_release(doc);
+        return revHistory;
     }
 }
 

diff --git a/Objective-C/Tests/DatabaseTest.m b/Objective-C/Tests/DatabaseTest.m
@@ -598,14 +598,6 @@ - (void) testSavePurgedDoc {
 
 #pragma mark Save Conflict Handler
 
-- (NSTimeInterval) checkTimestampUpdated:(CBLDocument*) doc
-                                        :(NSTimeInterval) oldTimestamp {
-    NSTimeInterval docTimestamp = doc.timestamp;
-    Assert(docTimestamp > oldTimestamp);
-
-    return docTimestamp;
-}
-
 - (void) testConflictHandler {
     NSError* error;
     NSString* docID = @"doc1";

diff --git a/Objective-C/Tests/DocumentTest.m b/Objective-C/Tests/DocumentTest.m
@@ -2320,9 +2320,8 @@ - (void) testDocumentRevisionHistory {
     Assert([defaultCollection saveDocument:doc error: &err]);
     Assert(doc._getRevisionHistory);
 
-    // Fails from LiteCore,only 1 rev, no rev history
-    // doc = [[defaultCollection documentWithID: @"doc1" error: &err] toMutable];
-    // Assert(doc._getRevisionHistory);
+    doc = [[defaultCollection documentWithID: @"doc1" error: &err] toMutable];
+    Assert(doc._getRevisionHistory);
 }
 
 #pragma clang diagnostic pop

diff --git a/Objective-C/Tests/VectorSearchTest.m b/Objective-C/Tests/VectorSearchTest.m
@@ -1188,7 +1188,7 @@ - (void) testVectorMatchLimitBoundary {
 
     // Check if error thrown for wrong limit values
     [self expectError: CBLErrorDomain code: CBLErrorInvalidQuery in: ^BOOL(NSError** err) {
-        NSString* sql = [self wordsQueryStringWithLimit: @10001];
+        NSString* sql = [self wordsQueryStringWithLimit: 10001];
         return [self.wordDB createQuery: sql error: err] != nil;
     }];
 }

diff --git a/Swift/Document.swift b/Swift/Document.swift
@@ -33,7 +33,7 @@ public class Document : DictionaryProtocol, Equatable, Hashable, Sequence {
         return impl.revisionID
     }
 
-    public var timestamp: Double {
+    public var timestamp: TimeInterval {
         return impl.timestamp
     }
 

diff --git a/Swift/Tests/DocumentTest.swift b/Swift/Tests/DocumentTest.swift
@@ -1901,8 +1901,7 @@ class DocumentTest: CBLTestCase {
         try defaultCollection!.save(document: doc)
         assert(doc._getRevisionHistory() != nil)
 
-        // Fails from LiteCore,only 1 rev, no rev history
-        // doc = try defaultCollection!.document(id: "doc1")!.toMutable();
-        // asser(doc._getRevisionHistory() != nil)
+        doc = try defaultCollection!.document(id: "doc1")!.toMutable();
+        assert(doc._getRevisionHistory() != nil)
     }
 }