Skip to content

CXXCBC-376 Create and Update bucket sending unnecessary fields to server #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2023
Merged

CXXCBC-376 Create and Update bucket sending unnecessary fields to server #451

merged 4 commits into from
Sep 19, 2023

Conversation

@Matt-Woz
Copy link
Contributor

@Matt-Woz Matt-Woz commented Sep 14, 2023

Changes:

  • Change BucketSettings unrequired fields to be optional
  • Update request encoding logic so the SDK doesn't send the fields unless they are specified

thejcfactor
thejcfactor reviewed Sep 15, 2023
View reviewed changes
@avsej avsej force-pushed the CXXCBC-376_Create_and_update_bucket_sending_unecessary_fields_to_server branch from 27024b7 to 5ad361d Compare September 18, 2023 16:04
@Matt-Woz Matt-Woz merged commit a873bb9 into couchbase:main Sep 19, 2023
@Matt-Woz Matt-Woz deleted the CXXCBC-376_Create_and_update_bucket_sending_unecessary_fields_to_server branch September 19, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thejcfactor thejcfactor thejcfactor left review comments

@avsej avsej avsej approved these changes

@DemetrisChr DemetrisChr Awaiting requested review from DemetrisChr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matt-Woz @avsej @thejcfactor