Skip to content

CXXCBC-374: create_bucket does not return a BucketExists error when a duplicate bucket is created #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 14, 2023
Merged

CXXCBC-374: create_bucket does not return a BucketExists error when a duplicate bucket is created #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0c6620e
Add check for status code 400 and bucket exists message
Matt-Woz Sep 13, 2023
9c8de1a
add test
Matt-Woz Sep 13, 2023
1ce9abf
Add history feature not avaialble to bucket create and update
Matt-Woz Sep 14, 2023
dd5b620
linting
Matt-Woz Sep 14, 2023
873a4fa
undo history retention change
Matt-Woz Sep 14, 2023
2f8638b
Merge branch 'main' into CXXCBC-374_create_bucket_does_not_return_buc…
Matt-Woz Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/operations/management/bucket_create.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ bucket_create_request::make_response(error_context::http&& ctx, const encoded_re
if (errors != nullptr) {
std::vector<std::string> error_list{};
for (const auto& [code, message] : errors->get_object()) {
if (message.get_string().find("Bucket with given name already exists") != std::string::npos) {
response.ctx.ec = errc::management::bucket_exists;
}
error_list.emplace_back(message.get_string());
}
if (!error_list.empty()) {
Expand Down
8 changes: 8 additions & 0 deletions test/test_integration_management.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,14 @@ TEST_CASE("integration: bucket management", "[integration]")
REQUIRE(bucket_settings.compression_mode == resp.bucket.compression_mode);
REQUIRE(bucket_settings.replica_indexes == resp.bucket.replica_indexes);
}

{
couchbase::core::operations::management::bucket_create_request req;
req.bucket = bucket_settings;
auto resp = test::utils::execute(integration.cluster, req);
REQUIRE(resp.ctx.ec == couchbase::errc::management::bucket_exists);
}

std::uint64_t old_quota_mb{ 0 };
{
couchbase::core::operations::management::bucket_get_all_request req{};
Expand Down