CXXCBC-316: Core txn get_optional after query issue #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have removed a doc in this transaction, and then call get_optional, we expect to just get an empty optional. However, the handling was raising a transaction_operation_failed. Simple fix - the get_doc call can return no error, and no document. When that happens and we are in a get_optional, we should just return the empty optional
avsej
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have removed a doc in this transaction, and then call
get_optional, we expect to just get an empty optional. However, the
handling was raising a transaction_operation_failed. Simple fix - the
get_doc call can return no error, and no document. When that happens
and we are in a get_optional, we should just return the empty optional.
While at it, added some simple
getandget_optionaltests that were missing. Andadded a test reproducing the issue Sergey saw.