CXXCBC-310 Transaction fit test errors #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we stage an insert, and get an ambiguous fail back, we look for the doc and examine it to see if we can retry, etc... When doing so, if the doc was staged successfully, we just need to make sure the that we use the staged_mutation's content, not the content in the staged_mutation's doc, as that will have the results of looking at the document after we staged it as a tombstone, so the content will be empty. This showed up in some ambiguous fail tests in fit. Simple fix.
avsej
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we stage an insert, and get an ambiguous fail back, we look for the
doc and examine it to see if we can retry, etc... When doing so, if
the doc was staged successfully, we just need to make sure the that we
use the staged_mutation's content, not the content in the
staged_mutation's doc, as that will have the results of looking at the
document after we staged it as a tombstone, so the content will be
empty. This showed up in some ambiguous fail tests in fit. Simple
fix.