Skip to content

Minor semantic changes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Minor semantic changes #6

wants to merge 4 commits into from

Conversation

VirajAgarwal1
Copy link
Contributor

Added architecture diagram and updated the fts index to refer to one in the root dir's scripts folder. Also, removed the shell script of the same from aws-lambda dir.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @VirajAgarwal1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to refine the project's setup and documentation. Based on the provided patch, it specifically updates the aws-lambdas/README.md to correct the command for creating the Full Text Search (FTS) index, ensuring it points to the correct script location. The PR description also indicates intentions to add an architecture diagram and remove a redundant shell script, though these specific changes are not included in the provided patch.

Highlights

  • Documentation Update: The command for creating the Full Text Search (FTS) index in aws-lambdas/README.md has been updated to node ../scripts/create-fts-index.js, ensuring it correctly references the script in the root directory's scripts folder.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the README to reflect the change in how the FTS index creation script is executed, now referencing the Node.js script directly instead of an npm script. This aligns with the description mentioning the removal of the shell script. The review suggests considering the use of npm run scripts for consistency and maintainability.

@VirajAgarwal1 VirajAgarwal1 self-assigned this Jun 20, 2025
@VirajAgarwal1 VirajAgarwal1 requested a review from shyam-cb June 20, 2025 10:02
@VirajAgarwal1 VirajAgarwal1 marked this pull request as draft June 24, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant