Improved main loop blocking with no internet connection #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without internet connection (e.g cable unplugged from the WAN port of a router)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed (improved) main loop blocking while calling myBot.getNewMessage without internet connection (e.g cable unplugged from the WAN port of a router, but Wi-Fi still presented).
There is till some blocking around 16 secs of duration each 10*m_minUpdateTime because of invoking reset(); but at least not each loop() iteration :)
The 16 sec block is caused by WiFiClientSecure::connect function, which also seems to be known issue
espressif/arduino-esp32#5418
Tested on esp8266 but perhaps should be similar behavior on esp32.