Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linkedin icon color doesn't exist when user use linkedin in share.yml #683

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

nshidqi
Copy link
Contributor

@nshidqi nshidqi commented Sep 7, 2022

Description

When users want to use Linkedin and Weibo for sharing by uncommenting them in share.yml, the LinkedIn icon doesn't have its color, whereas Weibo has its color. Turned out that Linkedin's icon color is missing in post.scss.
image

Solution:
Add Linkedin color in post.scss, the color is based on LinkedIn's official brand color:
https://brand.linkedin.com/content/brand/global/en_us/index/visual-identity/color-palettes
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/deploy.sh --dry-run (at the root of the project) locally and passed
  • I have tested this feature in the browser

Test Configuration

  • Browser type & version: Google Chrome Version 104.0.5112.102 (Official Build) (64-bit)
  • Operating system: Windows 11
  • Ruby version: ruby 3.1.2p20
  • Bundler version: Bundler version 2.3.21
  • Jekyll version: jekyll (4.2.2)

Checklist

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@cotes2020 cotes2020 merged commit 0dcd39d into cotes2020:master Sep 7, 2022
linkliu pushed a commit to linkliu/game-tech-post-old that referenced this pull request Sep 8, 2022
shihtiy-tw pushed a commit to shihtiy-tw/shihtiy-tw.github.io that referenced this pull request Nov 26, 2022
sanjidnet pushed a commit to sanjidnet/sanjidnet.github.io that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants