Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build and deploy via GH actions only (no deploy script) #664

Merged
merged 3 commits into from
Sep 7, 2022
Merged

feat: build and deploy via GH actions only (no deploy script) #664

merged 3 commits into from
Sep 7, 2022

Conversation

GriceTurrble
Copy link
Contributor

@GriceTurrble GriceTurrble commented Aug 13, 2022

New actions available in GitHub allow for building and deploying the site
completely from the actions workflow with minimal code.
The deploy.sh script is no longer necessary with these changes.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

Test Configuration

  • Browser type & version:
  • Operating system:
  • Ruby version:
  • Bundler version:
  • Jekyll version:

Checklist

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

_posts/2019-08-09-getting-started.md Outdated Show resolved Hide resolved
.github/workflows/pages-deploy.yml.hook Outdated Show resolved Hide resolved
tools/test.sh Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/pages-deploy.yml.hook Show resolved Hide resolved
_posts/2019-08-09-getting-started.md Outdated Show resolved Hide resolved
tools/test.sh Outdated Show resolved Hide resolved
@GriceTurrble
Copy link
Contributor Author

I think configure pages portion of the CI is failing, since this particular repo does not build out to a GitHub Pages site, no?

@cotes2020
Copy link
Owner

I think configure pages portion of the CI is failing, since this particular repo does not build out to a GitHub Pages site, no?

Yes, it seems that the project still needs to use test.sh in CI to avoid this problem

Galen Rice added 3 commits September 7, 2022 22:53
New actions available in GitHub allow for building and deploying the site
completely from the actions workflow with minimal code.
The deploy.sh script is no longer necessary with these changes.
@cotes2020 cotes2020 merged commit 45c58d8 into cotes2020:master Sep 7, 2022
sanjidnet pushed a commit to sanjidnet/sanjidnet.github.io that referenced this pull request Jan 9, 2023
Build and deploy via GH actions only (no deploy script)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants