Pasquale/cui 117 build a select like button#672
Open
pasqualevitiello wants to merge 2 commits intomainfrom
Open
Pasquale/cui 117 build a select like button#672pasqualevitiello wants to merge 2 commits intomainfrom
pasqualevitiello wants to merge 2 commits intomainfrom
Conversation
…oboxTrigger, MenuTrigger, etc
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Contributor
There was a problem hiding this comment.
1 issue found across 30 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/ui/public/r/registry.json">
<violation number="1" location="apps/ui/public/r/registry.json:3786">
P2: The new p-combobox-18 registry entry omits the lucide-react dependency even though the component imports SearchIcon. Add a dependencies list so consumers get the required package.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "combobox", | ||
| "select" | ||
| ], | ||
| "description": "Combobox with select trigger", |
Contributor
There was a problem hiding this comment.
P2: The new p-combobox-18 registry entry omits the lucide-react dependency even though the component imports SearchIcon. Add a dependencies list so consumers get the required package.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/ui/public/r/registry.json, line 3786:
<comment>The new p-combobox-18 registry entry omits the lucide-react dependency even though the component imports SearchIcon. Add a dependencies list so consumers get the required package.</comment>
<file context>
@@ -3773,8 +3773,30 @@
+ "combobox",
+ "select"
+ ],
+ "description": "Combobox with select trigger",
+ "files": [
+ {
</file context>
Suggested change
| "description": "Combobox with select trigger", | |
| "dependencies": [ | |
| "lucide-react" | |
| ], | |
| "description": "Combobox with select trigger", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: This PR introduces a
SelectButtoncomponent, helpful when you need a button that looks like a select trigger (eg. in combobox, autocomplete, menu and popover triggers).Summary by cubic
Adds SelectButton to give Combobox, Menu, and Popover a select-like trigger, with docs and examples. Implements CUI-117.
New Features
Refactors
Written for commit 2f216f9. Summary will update on new commits.