Skip to content

Pasquale/cui 117 build a select like button#672

Open
pasqualevitiello wants to merge 2 commits intomainfrom
pasquale/cui-117-build-a-select-like-button
Open

Pasquale/cui 117 build a select like button#672
pasqualevitiello wants to merge 2 commits intomainfrom
pasquale/cui-117-build-a-select-like-button

Conversation

@pasqualevitiello
Copy link
Contributor

@pasqualevitiello pasqualevitiello commented Feb 8, 2026

Screenshot 2026-02-08 at 14 20 32

TLDR: This PR introduces a SelectButton component, helpful when you need a button that looks like a select trigger (eg. in combobox, autocomplete, menu and popover triggers).

Summary by cubic

Adds SelectButton to give Combobox, Menu, and Popover a select-like trigger, with docs and examples. Implements CUI-117.

  • New Features

    • SelectButton: standalone, styled like SelectTrigger; usable as a render prop on other triggers.
    • New example p-combobox-18 and docs showing ComboboxTrigger with SelectButton.
    • Updated timezone combobox demo to use SelectButton.
  • Refactors

    • Triggers (Combobox, Autocomplete, Menu, Popover) now render children to support custom trigger content.
    • Added Icon elements with data-slot for Combobox/Autocomplete triggers.
    • Removed unused bookings-saved-filters example.
    • Upgraded @base-ui/react to 1.1.0.

Written for commit 2f216f9. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
coss-com Ready Ready Preview, Comment Feb 8, 2026 1:18pm
coss-examples-calcom Ready Ready Preview, Comment Feb 8, 2026 1:18pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
coss-com-origin Skipped Skipped Feb 8, 2026 1:18pm
coss-com-ui Skipped Skipped Feb 8, 2026 1:18pm

Request Review

@pasqualevitiello pasqualevitiello requested a review from a team February 8, 2026 13:18
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Pasquale/cui 117 build a select like button". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 30 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="apps/ui/public/r/registry.json">

<violation number="1" location="apps/ui/public/r/registry.json:3786">
P2: The new p-combobox-18 registry entry omits the lucide-react dependency even though the component imports SearchIcon. Add a dependencies list so consumers get the required package.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

"combobox",
"select"
],
"description": "Combobox with select trigger",
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The new p-combobox-18 registry entry omits the lucide-react dependency even though the component imports SearchIcon. Add a dependencies list so consumers get the required package.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/ui/public/r/registry.json, line 3786:

<comment>The new p-combobox-18 registry entry omits the lucide-react dependency even though the component imports SearchIcon. Add a dependencies list so consumers get the required package.</comment>

<file context>
@@ -3773,8 +3773,30 @@
+        "combobox",
+        "select"
+      ],
+      "description": "Combobox with select trigger",
+      "files": [
+        {
</file context>
Suggested change
"description": "Combobox with select trigger",
"dependencies": [
"lucide-react"
],
"description": "Combobox with select trigger",
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant