Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS-06: Solomachine Refactor #821

Merged
merged 13 commits into from
Jan 9, 2023
Merged

ICS-06: Solomachine Refactor #821

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6281f83
update solomachine for 02-client-refactor
AdityaSripal Aug 15, 2022
005cb5f
fix client message handler fns
AdityaSripal Aug 16, 2022
b8a55b0
address reviews
AdityaSripal Oct 31, 2022
c0ee11e
Merge branch 'main' of github.com:cosmos/ibc into aditya/solomachine-…
AdityaSripal Oct 31, 2022
5c8ee6f
continuted improvements
AdityaSripal Oct 31, 2022
bbde565
Update spec/client/ics-006-solo-machine-client/README.md
AdityaSripal Nov 29, 2022
92d5bef
Apply suggestions from code review
AdityaSripal Dec 13, 2022
1d71f8e
address colin review
AdityaSripal Dec 14, 2022
0f9eba1
deprecate header sequence
AdityaSripal Dec 14, 2022
cef04d0
Apply suggestions from code review
AdityaSripal Dec 14, 2022
7749fe7
address damian review
AdityaSripal Dec 14, 2022
34bd88c
Merge branch 'aditya/solomachine-refactor' of github.com:cosmos/ibc i…
AdityaSripal Dec 14, 2022
d6dc88a
formatting nits
Dec 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deprecate header sequence
  • Loading branch information
@AdityaSripal
AdityaSripal committed Dec 14, 2022
commit 0f9eba1a224750fefd4fa79cca8b98e681a06b9b
3 changes: 1 addition & 2 deletions spec/client/ics-006-solo-machine-client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ The `Height` of a solo machine is just a `uint64`, with the usual comparison ope

```typescript
interface Header {
sequence: uint64
AdityaSripal marked this conversation as resolved.
Show resolved Hide resolved
sequence: uint64 // deprecated
timestamp: uint64
signature: Signature
newPublicKey: PublicKey
Expand Down Expand Up @@ -167,7 +167,6 @@ function verifyClientMessage(clientMsg: ClientMessage) {
}

function verifyHeader(header: header) {
assert(header.sequence === clientState.consensusState.sequence)
assert(header.timestamp >= clientstate.consensusState.timestamp)
crodriguezvega marked this conversation as resolved.
Show resolved Hide resolved
headerData = {
NewPubKey: header.newPubKey,
Expand Down