Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS28: Cross-Chain Validation V1 #666

Merged
merged 34 commits into from
Aug 9, 2022
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
79becaf
ICS 28 CCV draft w/ init and validator set update (#640)
mpoke Feb 10, 2022
e548e72
merge CODEOWNERS from master
mpoke Feb 24, 2022
f637f0c
ICS28: CCV draft w/ complete unbonding (#646)
mpoke Feb 28, 2022
0f132dc
ICS28: Extend consumer InitGenesis (#659)
mpoke Feb 28, 2022
5292796
ICS28: Consumer Initiated Slashing (aka Evidence) (#663)
mpoke Mar 23, 2022
723af4d
ICS28: Remove CCV channel state (#678)
mpoke Mar 23, 2022
c626454
Update technical_specification.md
mpoke Mar 28, 2022
28d46ee
ICS28: Replace "Initiator" w/ "Caller" and “Trigger Event” (#696)
mpoke Apr 4, 2022
51dd64d
ICS28: Handle pending proposals to spawn consumer chains (#697)
mpoke Apr 4, 2022
2322702
ICS28: Remove genesisHash from specification (#699)
mpoke Apr 4, 2022
a6c9861
ICS28: CCV Reward Distribution subprotocol (#704)
mpoke Apr 20, 2022
6a04566
ICS28: Set initH in onChanOpenConfirm (#705)
mpoke Apr 20, 2022
dfc0398
ICS28: Enable the removal of a consumer chain from the provider (#707)
mpoke May 10, 2022
484b02c
ICS28: Remove BeforeUnbondingOpCompleted (#711)
mpoke May 10, 2022
9bdba66
ICS28: Update SlashPacketData (#728)
mpoke May 10, 2022
a6bc8d1
ICS28: Remove dependency on Tendermint and ABCI (#730)
mpoke May 11, 2022
0b3c84a
call UnbondMaturePackets() earlier (#747)
mpoke May 20, 2022
b7611ae
fix edge case enabled by aggregation (#746)
mpoke May 20, 2022
a635623
Use `h < hp'` instead of `h <= hp'` in Bond-Based Consumer Voting Pow…
danwt May 20, 2022
fe3c111
replace slashRequests w/ downtimeSlashRequests (#745)
mpoke May 20, 2022
76f2577
ics28 update sendPacket (#756)
mpoke May 23, 2022
3842922
ICS28: Restructure technical spec (#760)
mpoke Jun 9, 2022
ad30596
ICS28: Unbonding ops are put on hold even w/o consumer chains (#763)
mpoke Jun 9, 2022
5be51c0
Use currentTimestamp() >= p.stopTime in StopConsumerChainProposalHand…
danwt Jun 20, 2022
3713192
adding consumerUnbondingPeriod (#771)
mpoke Jun 23, 2022
6187e04
fix sendFungibleTokens signature
mpoke Jun 23, 2022
f1b1040
Merge branch 'master' into marius/ccv
mpoke Jun 23, 2022
7ea1ce6
Merge branch 'marius/ccv' of github.com:cosmos/ibc into marius/ccv
mpoke Jun 23, 2022
6ebbd60
add authors
mpoke Jun 24, 2022
5265e0b
ICS28: Removing the only consumer chain (#770)
mpoke Jun 27, 2022
b967c18
add conditions for CreateConsumerClient and StopConsumerChain (#775)
mpoke Jun 27, 2022
5ea9021
update created date
mpoke Jun 27, 2022
5d3b778
Merge branch 'main' into marius/ccv
mpoke Aug 1, 2022
195c36c
ICS28: Account for slashing in Bond-Based Consumer Voting Power prope…
mpoke Aug 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix edge case enabled by aggregation (#746)
  • Loading branch information
mpoke authored May 20, 2022
commit b7611ae10daef336c839516b8c59480a65147f36
Original file line number Diff line number Diff line change
Expand Up @@ -1777,16 +1777,21 @@ function UpdateValidatorSet(changes: [ValidatorUpdate]) {
foreach update IN changes {
addr := hash(update.pubKey)
if addr NOT IN validatorSet.Keys() {
// new validator bonded
abortSystemUnless(update.power > 0)
// add new CrossChainValidator to validator set
val := CrossChainValidator{
address: addr,
power: update.power
// new validator bonded;
// note that due pendingChanges.Aggregate(),
// a validator can be added to the valset and
// then removed in the subsequent block,
// resulting in update.power == 0
if update.power > 0 {
// add new CrossChainValidator to validator set
val := CrossChainValidator{
address: addr,
power: update.power
}
validatorSet[addr] = val
// call AfterCCValidatorBonded hook
AfterCCValidatorBonded(addr)
}
validatorSet[addr] = val
// call AfterCCValidatorBonded hook
AfterCCValidatorBonded(addr)
}
else if update.power == 0 {
// existing validator begins unbonding
Expand All @@ -1808,15 +1813,15 @@ function UpdateValidatorSet(changes: [ValidatorUpdate]) {
- `changes` contains the aggregated validator updates from `pendingChanges` before it was emptied.
- **Postcondition**
- For each validator `update` in `changes`,
- if the validator is not in the validator set, then
- if the validator is not in the validator set and `update.power > 0`, then
- a new `CrossChainValidator` is added to `validatorSet`;
- the `AfterCCValidatorBonded` hook is called;
- otherwise, if the validator's new power is `0`, then,
- the validator is removed from `validatorSet`;
- the `AfterCCValidatorBeginUnbonding` hook is called;
- otherwise, the validator's power is updated.
- **Error Condition**
- Receiving a validator `update`, such that the validator is not in the validator set and `update.power = 0`.
- None.

<!-- omit in toc -->
#### **[CCV-CCF-UMP.1]**
Expand Down