Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: impl packet receipt query #7513

Merged
merged 8 commits into from
Oct 29, 2024
+987 −40
Merged

chore: impl packet receipt query #7513

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a52c9ae
feat: add v2 packet commitment query
damiannolan Oct 21, 2024
fe9b9f6
chore: add cli for packet commitment query with abci proof
damiannolan Oct 22, 2024
aefd9d3
chore: impl packet acknowledgement query
damiannolan Oct 22, 2024
b8df8b2
Merge branch 'feat/ibc-eureka' into damian/7478-packet-ack-query
damiannolan Oct 23, 2024
99e4e74
fix: update identifier validation in grpcs
damiannolan Oct 23, 2024
285db5e
chore: impl packet receipt query
damiannolan Oct 23, 2024
3a1c3ec
Merge branch 'feat/ibc-eureka' into damian/7478-packet-receipt-query
damiannolan Oct 28, 2024
b6e5cb8
Merge branch 'feat/ibc-eureka' into damian/7478-packet-receipt-query
damiannolan Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'feat/ibc-eureka' into damian/7478-packet-receipt-query
@damiannolan
damiannolan committed Oct 28, 2024
commit 3a1c3ecb544a08def810cbf8db61d432535f9b0a
84 changes: 42 additions & 42 deletions modules/core/04-channel/v2/types/query.pb.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/core/04-channel/v2/types/query.pb.gw.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/ibc/core/channel/v2/query.proto
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ service Query {

// PacketAcknowledgement queries a stored acknowledgement commitment hash.
rpc PacketAcknowledgement(QueryPacketAcknowledgementRequest) returns (QueryPacketAcknowledgementResponse) {
option (google.api.http).get = "/ibc/core/channel/v2/channels/{channel_id}/acknowledgements/{sequence}";
option (google.api.http).get = "/ibc/core/channel/v2/channels/{channel_id}/packet_acks/{sequence}";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to packet_acks, can make packet_acknowledgements if people find it better

}

// PacketReceipt queries a stored packet receipt.
You are viewing a condensed version of this merge commit. You can view the full changes here.