fix: avoid invalid identifier error when validate genesis #7397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that contains localhost client
mmsqe
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
colin-axner
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Thank you @mmsqe for reporting the issue and providing a fix. I left a comment on an alternative solution, let me know what you think
colin-axner
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Thanks @mmsqe for the followup! Everything looks good to me
|
Should we backport this? |
Would be nice if we can backport to v8.5.x. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: avoid invalid identifier error when validate genesis that contains localhost client * Apply suggestions from code review * skip (cherry picked from commit ff2b668) # Conflicts: # CHANGELOG.md # modules/core/03-connection/types/genesis.go # modules/core/03-connection/types/genesis_test.go
10 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: avoid invalid identifier error when validate genesis that contains localhost client * Apply suggestions from code review * skip (cherry picked from commit ff2b668) # Conflicts: # CHANGELOG.md
10 tasks
colin-axner
added a commit
that referenced
this pull request
Oct 8, 2024
…7397) (#7403) * fix: avoid invalid identifier error when validate genesis (#7397) * fix: avoid invalid identifier error when validate genesis that contains localhost client * Apply suggestions from code review * skip (cherry picked from commit ff2b668) # Conflicts: # CHANGELOG.md # modules/core/03-connection/types/genesis.go # modules/core/03-connection/types/genesis_test.go * chore: changelog cleanup * chore: fix imports --------- Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
colin-axner
added a commit
that referenced
this pull request
Oct 8, 2024
…7397) (#7404) * fix: avoid invalid identifier error when validate genesis (#7397) * fix: avoid invalid identifier error when validate genesis that contains localhost client * Apply suggestions from code review * skip (cherry picked from commit ff2b668) # Conflicts: # CHANGELOG.md * chore: changelog cleanup --------- Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that contains localhost client
Description
closes: #7396
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.