ICS4: Write ErrorReceipt for previous upgrade on Reinitialization #5732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
colin-axner and
damiannolan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5732 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 199 199
Lines 15203 15208 +5
=======================================
+ Hits 12389 12394 +5
Misses 2348 2348
Partials 466 466
|
damiannolan
reviewed
Jan 25, 2024
Comment on lines
56
to
60
| _, priorUpgradeExists := k.GetUpgrade(ctx, portID, channelID) | ||
| if priorUpgradeExists { | ||
| // invalidating previous upgrade | ||
| k.WriteErrorReceipt(ctx, portID, channelID, types.NewUpgradeError(channel.UpgradeSequence, types.ErrInvalidUpgrade)) | ||
| } |
There was a problem hiding this comment.
I think we can add HasUpgrade to keeper to save on minimal gas
if k.HasUpgrade(ctx, portId, channelID) {
k.WriteErrorReceipt(ctx, portID, channelID, upgradeErr)
}
colin-axner
added
priority
DimitrisJim
approved these changes
Jan 25, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
* fix reinitialization * write error receipt on reinitialization * gofumpt * switch to Has instead of Get * imp: HasUpgrade -> hasUpgrade --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 574a639)
DimitrisJim
pushed a commit
that referenced
this pull request
Jan 25, 2024
…) (#5743) * fix reinitialization * write error receipt on reinitialization * gofumpt * switch to Has instead of Get * imp: HasUpgrade -> hasUpgrade --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 574a639) Co-authored-by: Aditya <adityasripal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writes error receipt for previous upgrade attempt if we initialize a new one. This allows the counterparty to cancel their upgrade and retry on the latest attempt
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.