test: add test for unint64 overflow on limit #5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
colin-axner
reviewed
Jan 24, 2024
Comment on lines
+825
to
+828
| // Nothing should be pruned, by passing in a limit of math.MaxUint64, overflow occurs | ||
| // when initializing end to pruningSequenceStart + limit. This results in end always being | ||
| // equal to start - 1 and thereby not entering the for loop. | ||
| // We expect 10 acks, 10 receipts and pruningSequenceStart == 1 (loop not entered). |
There was a problem hiding this comment.
crazy, so it doesn't panic, it just wraps around. I guess by construction this is safe. Should we add an in-line comment in the code in case someone tries to refactor it?
There was a problem hiding this comment.
absolutely! Added a small note, feel free (you or anyone else) to expand on my dry-ness 😅
colin-axner
approved these changes
Jan 24, 2024
crodriguezvega
approved these changes
Jan 24, 2024
|
Awesome @DimitrisJim, nice one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap around is guaranteed in this case, ref https://go.dev/ref/spec#Integer_overflow. For signed ints this is also deterministic apparently.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.