Wrap error returned from upgrade ACK application callbacks #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
…-application-callbacks
AdityaSripal
approved these changes
Jan 24, 2024
crodriguezvega
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks, @chatton! If you thinks it's worth, maybe we could add a test where the callback returns an UpgradeError with a crazy upgrade sequence and then we verify that the error receipt written contains the channel's sequence.
|
Great suggestion @crodriguezvega , added a test case |
chatton
deleted the
cian/issue#5694-wrap-error-returned-from-ack-application-callbacks
branch
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
(cherry picked from commit b59f6b0)
damiannolan
added a commit
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5694
This feels a bit dirty due to having the fetch the channel just for the upgrade sequence.
An alternative that would technically work is wrapping the error in a non upgrade error. As the direct cast would fail and it would default to using the current channel upgrade sequence. But this feels a bit worse.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.