Add testing for ICA events #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
chatton
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
chatton
commented
Jan 25, 2024
| }, | ||
| { | ||
| "host submodule disabled", func() { | ||
| suite.chainB.GetSimApp().ICAHostKeeper.SetParams(suite.chainB.GetContext(), types.NewParams(false, []string{})) | ||
| }, false, | ||
| "", // events are not emitted when the host submodule is disabled. |
There was a problem hiding this comment.
I was thinking, is this actually desired behaviour? This could be useful debugging information via events.
There was a problem hiding this comment.
Yeah, I don't see any harm on maybe emitting the event with that information...
crodriguezvega
approved these changes
Feb 2, 2024
| }, | ||
| { | ||
| "host submodule disabled", func() { | ||
| suite.chainB.GetSimApp().ICAHostKeeper.SetParams(suite.chainB.GetContext(), types.NewParams(false, []string{})) | ||
| }, false, | ||
| "", // events are not emitted when the host submodule is disabled. |
There was a problem hiding this comment.
Yeah, I don't see any harm on maybe emitting the event with that information...
chatton
commented
Feb 8, 2024
| @@ -22,6 +22,11 @@ import ( | |||
| channeltypes "github.com/cosmos/ibc-go/v8/modules/core/04-channel/types" | |||
There was a problem hiding this comment.
all the changes in E2E are linter fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
merge after #5686ref: #2823
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.