Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use local clock time as reference time for timeout timestamp if later than consensus state timestamp #568

Merged
merged 6 commits into from
Dec 2, 2021
Merged

use local clock time as reference time for timeout timestamp if later than consensus state timestamp #568

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e91bbc
use local clock time as reference time if it is later than the consen…
crodriguezvega Nov 29, 2021
af9f1eb
add comment
crodriguezvega Nov 30, 2021
b6ab2dc
update command description
crodriguezvega Nov 30, 2021
083d9f1
add entry to changelog
crodriguezvega Dec 1, 2021
b734f8d
return error is clock time is less or equal than Jan 1st 1970 12:00 AM
crodriguezvega Dec 1, 2021
ad9cabd
Merge branch 'main' into carlos/508-packet-timeout-timestamp
crodriguezvega Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update command description
  • Loading branch information
@crodriguezvega
crodriguezvega committed Nov 30, 2021
commit b6ab2dcda7d86941a0f2fe52a8a11a88decdc033
7 changes: 4 additions & 3 deletions modules/apps/transfer/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ func NewTransferTxCmd() *cobra.Command {
Short: "Transfer a fungible token through IBC",
Long: strings.TrimSpace(`Transfer a fungible token through IBC. Timeouts can be specified
as absolute or relative using the "absolute-timeouts" flag. Timeout height can be set by passing in the height string
in the form {revision}-{height} using the "packet-timeout-height" flag. Relative timeouts are added to
the block height and block timestamp queried from the latest consensus state corresponding
to the counterparty channel. Any timeout set to 0 is disabled.`),
in the form {revision}-{height} using the "packet-timeout-height" flag. Relative timeout height is added to the block
height queried from the latest consensus state corresponding to the counterparty channel. Relative timeout timestamp
is added to the greater value of the local clock time and the block timestamp queried from the latest consensus state
corresponding to the counterparty channel. Any timeout set to 0 is disabled.`),
Example: fmt.Sprintf("%s tx ibc-transfer transfer [src-port] [src-channel] [receiver] [amount]", version.AppName),
Args: cobra.ExactArgs(4),
RunE: func(cmd *cobra.Command, args []string) error {
Expand Down