Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ica: genesis state validation #554

Merged
merged 6 commits into from
Nov 29, 2021
Merged

ica: genesis state validation #554

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b76cf6
adding genesis state validation
damiannolan Nov 19, 2021
631b014
adding genesis state validation tests
damiannolan Nov 19, 2021
a71bd0c
Update modules/apps/27-interchain-accounts/types/genesis_test.go
damiannolan Nov 29, 2021
1f50695
Update modules/apps/27-interchain-accounts/types/genesis_test.go
damiannolan Nov 29, 2021
5686950
adding ValidateAccountAddress helper to reduce code duplication
damiannolan Nov 29, 2021
636b73c
Merge branch 'interchain-accounts' into damian/535-ica-genesis-state-…
damiannolan Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding genesis state validation tests
  • Loading branch information
@damiannolan
damiannolan committed Nov 19, 2021
commit 631b0145451e8204cc65c721d14acdcdbec1eb96
311 changes: 311 additions & 0 deletions modules/apps/27-interchain-accounts/types/genesis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,311 @@
package types_test

import (
"github.com/cosmos/ibc-go/v2/modules/apps/27-interchain-accounts/types"
ibctesting "github.com/cosmos/ibc-go/v2/testing"
)

func (suite *TypesTestSuite) TestValidateGenesisState() {
var (
genesisState types.GenesisState
)

testCases := []struct {
name string
malleate func()
expPass bool
}{
{
"success",
func() {},
true,
},
{
"failed to validate - empty value",
func() {
genesisState = types.GenesisState{}
},
false,
},
{
"failed to validate - invalid controller genesis",
func() {
genesisState = *types.NewGenesisState(types.ControllerGenesisState{Ports: []string{"invalid|port"}}, types.DefaultHostGenesis())
},
false,
},
{
"failed to validate - invalid host genesis",
func() {
genesisState = *types.NewGenesisState(types.DefaultControllerGenesis(), types.HostGenesisState{})
},
false,
},
}

for _, tc := range testCases {
suite.Run(tc.name, func() {
genesisState = *types.DefaultGenesis()

tc.malleate() // malleate mutates test data

err := genesisState.Validate()

if tc.expPass {
suite.Require().NoError(err, tc.name)
} else {
suite.Require().Error(err, tc.name)
}
})
}
}

func (suite *TypesTestSuite) TestValidateControllerGenesisState() {
var (
genesisState types.ControllerGenesisState
)

testCases := []struct {
name string
malleate func()
expPass bool
}{
{
"success",
func() {},
true,
},
{
"failed to validate active channel - invalid port identifier",
func() {
activeChannels := []types.ActiveChannel{
{
PortId: "invalid|port",
ChannelId: ibctesting.FirstChannelID,
},
}

genesisState = types.NewControllerGenesisState(activeChannels, []types.RegisteredInterchainAccount{}, []string{})
},
false,
},
{
"failed to validate active channel - invalid channel identifier",
func() {
activeChannels := []types.ActiveChannel{
{
PortId: TestPortID,
ChannelId: "invalid|channel",
},
}

genesisState = types.NewControllerGenesisState(activeChannels, []types.RegisteredInterchainAccount{}, []string{})
},
false,
},
{
"failed to validate registered account - invalid port identifier",
func() {
activeChannels := []types.ActiveChannel{
{
PortId: TestPortID,
ChannelId: ibctesting.FirstChannelID,
},
}

registeredAccounts := []types.RegisteredInterchainAccount{
{
PortId: "invalid|port",
AccountAddress: TestOwnerAddress,
},
}

genesisState = types.NewControllerGenesisState(activeChannels, registeredAccounts, []string{})
},
false,
},
{
"failed to validate registered account - invalid port identifier",
damiannolan marked this conversation as resolved.
Show resolved Hide resolved
func() {
activeChannels := []types.ActiveChannel{
{
PortId: TestPortID,
ChannelId: ibctesting.FirstChannelID,
},
}

registeredAccounts := []types.RegisteredInterchainAccount{
{
PortId: TestPortID,
AccountAddress: "",
},
}

genesisState = types.NewControllerGenesisState(activeChannels, registeredAccounts, []string{})
},
false,
},
{
"failed to validate controller ports - invalid port identifier",
func() {
activeChannels := []types.ActiveChannel{
{
PortId: TestPortID,
ChannelId: ibctesting.FirstChannelID,
},
}

registeredAccounts := []types.RegisteredInterchainAccount{
{
PortId: TestPortID,
AccountAddress: TestOwnerAddress,
},
}

genesisState = types.NewControllerGenesisState(activeChannels, registeredAccounts, []string{"invalid|port"})
},
false,
},
}

for _, tc := range testCases {
suite.Run(tc.name, func() {
genesisState = types.DefaultControllerGenesis()

tc.malleate() // malleate mutates test data

err := genesisState.Validate()

if tc.expPass {
suite.Require().NoError(err, tc.name)
} else {
suite.Require().Error(err, tc.name)
}
})
}
}

func (suite *TypesTestSuite) TestValidateHostGenesisState() {
var (
genesisState types.HostGenesisState
)

testCases := []struct {
name string
malleate func()
expPass bool
}{
{
"success",
func() {},
true,
},
{
"failed to validate active channel - invalid port identifier",
func() {
activeChannels := []types.ActiveChannel{
{
PortId: "invalid|port",
ChannelId: ibctesting.FirstChannelID,
},
}

genesisState = types.NewHostGenesisState(activeChannels, []types.RegisteredInterchainAccount{}, types.PortID)
},
false,
},
{
"failed to validate active channel - invalid channel identifier",
func() {
activeChannels := []types.ActiveChannel{
{
PortId: TestPortID,
ChannelId: "invalid|channel",
},
}

genesisState = types.NewHostGenesisState(activeChannels, []types.RegisteredInterchainAccount{}, types.PortID)
},
false,
},
{
"failed to validate registered account - invalid port identifier",
func() {
activeChannels := []types.ActiveChannel{
{
PortId: TestPortID,
ChannelId: ibctesting.FirstChannelID,
},
}

registeredAccounts := []types.RegisteredInterchainAccount{
{
PortId: "invalid|port",
AccountAddress: TestOwnerAddress,
},
}

genesisState = types.NewHostGenesisState(activeChannels, registeredAccounts, types.PortID)
},
false,
},
{
"failed to validate registered account - invalid port identifier",
damiannolan marked this conversation as resolved.
Show resolved Hide resolved
func() {
activeChannels := []types.ActiveChannel{
{
PortId: TestPortID,
ChannelId: ibctesting.FirstChannelID,
},
}

registeredAccounts := []types.RegisteredInterchainAccount{
{
PortId: TestPortID,
AccountAddress: "",
},
}

genesisState = types.NewHostGenesisState(activeChannels, registeredAccounts, types.PortID)
},
false,
},
{
"failed to validate controller ports - invalid port identifier",
func() {
activeChannels := []types.ActiveChannel{
{
PortId: TestPortID,
ChannelId: ibctesting.FirstChannelID,
},
}

registeredAccounts := []types.RegisteredInterchainAccount{
{
PortId: TestPortID,
AccountAddress: TestOwnerAddress,
},
}

genesisState = types.NewHostGenesisState(activeChannels, registeredAccounts, "invalid|port")
},
false,
},
}

for _, tc := range testCases {
suite.Run(tc.name, func() {
genesisState = types.DefaultHostGenesis()

tc.malleate() // malleate mutates test data

err := genesisState.Validate()

if tc.expPass {
suite.Require().NoError(err, tc.name)
} else {
suite.Require().Error(err, tc.name)
}
})
}
}