Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapshotter extension #4723
Add snapshotter extension #4723
Changes from 24 commits
3722182
ac49db0
a1e523e
bf55119
15d56ae
6072ed0
7030272
bf6a7ae
b5babb3
3c43175
a0ad090
3a129a0
572d8a1
369d309
658250b
38ded82
86ee5d3
80bfaf8
dde9563
47f4745
43b71db
d639e2d
0765a17
e818769
cb877a5
82a813f
67eb3e9
3f492a1
c34461c
bc0b35d
ea57365
7d08468
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 8 in modules/light-clients/08-wasm/keeper/snapshotter.go
GitHub Actions / lint
Check failure on line 11 in modules/light-clients/08-wasm/keeper/snapshotter.go
GitHub Actions / lint
Check failure on line 13 in modules/light-clients/08-wasm/keeper/snapshotter.go
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate contract test case? Or are we assuming a node would never be provided such a snapshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate contract test would fail with the current test structure on the initial store code call in 08-wasm here: https://github.com/cosmos/ibc-go/blob/feat/wasm-clients/modules/light-clients/08-wasm/keeper/keeper.go#L103-L105
We might be able to work around it tho.
But that being said, all calls to the vm
StoreCode
are idempotent so it should just behave as if its a no-op if its ever reached. I think it would be quite hard for a node to obtain a snapshot with duplicate contracts, impossible even?Check failure on line 64 in modules/light-clients/08-wasm/keeper/snapshotter_test.go
GitHub Actions / lint
Check failure on line 7 in modules/light-clients/08-wasm/testing/simapp/test_helpers.go
GitHub Actions / lint
Check failure on line 12 in modules/light-clients/08-wasm/testing/simapp/test_helpers.go
GitHub Actions / lint
Check failure on line 23 in modules/light-clients/08-wasm/testing/simapp/test_helpers.go
GitHub Actions / lint
Check failure on line 26 in modules/light-clients/08-wasm/testing/simapp/test_helpers.go
GitHub Actions / lint