Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for recover client on message server. #4503

Merged
merged 3 commits into from
Aug 31, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Further clean-up, remove declaration of unmutated vars.
  • Loading branch information
DimitrisJim committed Aug 31, 2023
commit 08d72b82c3188033ffa482d2505785a5c698396b
12 changes: 4 additions & 8 deletions modules/core/keeper/msg_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -780,11 +780,7 @@ func (suite *KeeperTestSuite) TestUpgradeClient() {
}

func (suite *KeeperTestSuite) TestRecoverClient() {
var (
subject, substitute string
subjectClientState exported.ClientState
msg *clienttypes.MsgRecoverClient
)
var msg *clienttypes.MsgRecoverClient

testCases := []struct {
name string
Expand Down Expand Up @@ -819,12 +815,12 @@ func (suite *KeeperTestSuite) TestRecoverClient() {

subjectPath := ibctesting.NewPath(suite.chainA, suite.chainB)
suite.coordinator.SetupClients(subjectPath)
subject = subjectPath.EndpointA.ClientID
subjectClientState = suite.chainA.GetClientState(subject)
subject := subjectPath.EndpointA.ClientID
subjectClientState := suite.chainA.GetClientState(subject)

substitutePath := ibctesting.NewPath(suite.chainA, suite.chainB)
suite.coordinator.SetupClients(substitutePath)
substitute = substitutePath.EndpointA.ClientID
substitute := substitutePath.EndpointA.ClientID

// update substitute twice
err := substitutePath.EndpointA.UpdateClient()
Expand Down