Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post v5.3.0 release chores #3562

Merged
merged 10 commits into from
May 23, 2023
Merged

Conversation

charleenfei
Copy link
Contributor

updates the compatibility test matrices and e2e simd and icad workflows


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @charleenfei; and great that these changes can be automated now! 🤖

I think we are missing a couple of though:

  • Updating the changelog with the entries for the v5.3.0 release.
  • Updating RELEASES.md with the new supported release line and the versions of dependencies use in v5.3.0.
  • Adding the new release to the docs site.

@charleenfei
Copy link
Contributor Author

Thank you, @charleenfei; and great that these changes can be automated now! 🤖

I think we are missing a couple of though:

  • Updating the changelog with the entries for the v5.3.0 release.
  • Updating RELEASES.md with the new supported release line and the versions of dependencies use in v5.3.0.
  • Adding the new release to the docs site.

hi! i did update the CHANGELOG on the v5.3.x line, should I update it on main as well? I also updated the RELEASES.md here.

@charleenfei
Copy link
Contributor Author

regarding the docs, i was waiting for the large bulk of docs migrations work from @srdtrk to stabilise, but it looks like he's already added v.5.3 here

@crodriguezvega
Copy link
Contributor

crodriguezvega commented May 16, 2023

i did update the CHANGELOG on the v5.3.x line, should I update it on main as well?

Yes, I would also update main with the changelog for v5.3.0.

I also updated the RELEASES.md here

Cool. I didn't see that it was done separately.

regarding the docs, i was waiting for the large bulk of docs migrations work from @srdtrk to stabilise, but it looks like he's already added v.5.3 here

Maybe we could still update the existing website, since the new docusaurus site has not been deployed yet, right?

@charleenfei charleenfei requested a review from srdtrk as a code owner May 16, 2023 13:06
docs/versions Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this file do? or where is it used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used to generate the old docs (tells docs to pull docs from this version's github tag too)

@charleenfei charleenfei merged commit 1804597 into main May 23, 2023
@charleenfei charleenfei deleted the charly/post-v5.3.0-release-chores branch May 23, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants