Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add automatic in-place migrations for 02-client-refactor (v7) #2819

Merged
merged 16 commits into from
Nov 29, 2022
Merged

feat: add automatic in-place migrations for 02-client-refactor (v7) #2819

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0f90c1e
refactor: add automatic migrations for 02-client-refactor
colin-axner Nov 23, 2022
9d7c048
review: apply self nits
colin-axner Nov 23, 2022
fa08b63
chore: add changelog entry
colin-axner Nov 23, 2022
ae2b1c2
test: add an additional test for improperly registered codecs
colin-axner Nov 23, 2022
bf2a11b
Merge branch 'main' into colin/1863-02-client-migrations
colin-axner Nov 23, 2022
af99600
Merge branch 'main' of github.com:cosmos/ibc-go into colin/1863-02-cl…
colin-axner Nov 23, 2022
ee02a0b
Apply suggestions from code review
colin-axner Nov 29, 2022
cd6b54d
chore: improve error message to be more explicit
colin-axner Nov 29, 2022
df50f0e
chore: rename pruneClientConsensusStates to removeAllClientConsensusS…
colin-axner Nov 29, 2022
8881fdc
refactor: use coventional unmarshal/marshal format
colin-axner Nov 29, 2022
da0ae8e
Merge branch 'colin/1863-02-client-migrations' of github.com:cosmos/i…
colin-axner Nov 29, 2022
5d9d6a1
chore: improve error message by including clientID
colin-axner Nov 29, 2022
9013ef2
imp: rename assertLocalhostClients to assertNoLocalhostClients
colin-axner Nov 29, 2022
8e2b93a
Merge branch 'main' of github.com:cosmos/ibc-go into colin/1863-02-cl…
colin-axner Nov 29, 2022
a3a3490
Merge branch 'main' of github.com:cosmos/ibc-go into colin/1863-02-cl…
colin-axner Nov 29, 2022
478d694
chore: make lint-fix
colin-axner Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: improve error message by including clientID
  • Loading branch information
@colin-axner
colin-axner committed Nov 29, 2022
commit 5d9d6a11553369c879c877b7ef92dc01080bda46
2 changes: 1 addition & 1 deletion modules/core/02-client/migrations/v7/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func handleSolomachineMigration(ctx sdk.Context, store sdk.KVStore, cdc codec.Bi

bz := clientStore.Get(host.ClientStateKey())
if bz == nil {
return clienttypes.ErrClientNotFound
return sdkerrors.Wrapf(clienttypes.ErrClientNotFound, "clientID %s", clientID)
}

var any codectypes.Any
Expand Down